https://bugs.documentfoundation.org/show_bug.cgi?id=154269

V Stuart Foote <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heiko.tietze@documentfounda
                   |                            |tion.org
             Status|NEEDINFO                    |NEW
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=12
                   |                            |2322

--- Comment #6 from V Stuart Foote <[email protected]> ---
(In reply to Jim Raykowski from comment #5)
> svx/source/dialog/srchdlg.cxx
> SvxSearchDialog ctor
>     //tdf#122322
>     nRememberSize =
> officecfg::Office::Common::Misc::FindReplaceRememberedSearches::get();
>     if (nRememberSize<1)
>        nRememberSize = 1; //0 crashes with no results found
> 
> svx/source/tbxctrls/tbunosearchcontrollers.cxx
> FindTextFieldControl::Remember_Impl
>     if (nCount == REMEMBER_SIZE)
>         m_xWidget->remove(REMEMBER_SIZE-1);

Thanks Jim. 

Both look to use the same FindTextFieldControl() but manage their entries
differently.

And the 'Findbar' keeps its REMEMBER_SIZE fixed at 10 [1] when instantiated,
and did not get assigned the same nRememberSize for the
FindReplaceRememberedSearches handling that the Find and Replace dialog
received [2] with some tweaks.

Kind of seems like it should have.  So that the 'Findbar' (also the selector in
UI for the string the Navigator uses for repeat) work from the same array/stack
of strings the 'Find and Replace' dialog does.

@Heiko?


=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbunosearchcontrollers.cxx?a=true&r=9ddbce1e#76
[2] https://gerrit.libreoffice.org/c/core/+/67614/ for bug 122322

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to