https://bugs.documentfoundation.org/show_bug.cgi?id=116129

Andreas Heinisch <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected] |[email protected]
                   |desktop.org                 |
             Status|NEW                         |ASSIGNED

--- Comment #10 from Andreas Heinisch <[email protected]> ---
The relevant code for the clearContents method is in column3.cxx:

// Delete attributes just now
if ((nDelFlag & InsertDeleteFlags::ATTRIB) == InsertDeleteFlags::ATTRIB)
    pAttrArray->DeleteArea( nStartRow, nEndRow );
else if ((nDelFlag & InsertDeleteFlags::HARDATTR) ==
InsertDeleteFlags::HARDATTR)
    pAttrArray->DeleteHardAttr( nStartRow, nEndRow );

So the InsertDeleteFlags::ATTRIB checks for HARDATTR | STYLES. Hence, calling
clearContents using just with the STYLES attribute never deletes anything from
the selected cells.

Changing it to (nDelFlag & InsertDeleteFlags::ATTRIB) !=
InsertDeleteFlags::NONE makes the next statement obsolete (like himajin100000
pointed out).

So I would suggest to change it to:
// Delete attributes just now
if ((nDelFlag & InsertDeleteFlags::STYLES) == InsertDeleteFlags::STYLES)
    pAttrArray->DeleteArea( nStartRow, nEndRow );
if ((nDelFlag & InsertDeleteFlags::HARDATTR) == InsertDeleteFlags::HARDATTR)
    pAttrArray->DeleteHardAttr( nStartRow, nEndRow );

But I am not sure if the actual results are expected. I will attach them to the
bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to