https://bugs.documentfoundation.org/show_bug.cgi?id=139359

Eyal Rozenberg <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

--- Comment #13 from Eyal Rozenberg <[email protected]> ---
(In reply to Mike Kaganski from comment #5)
> 1. Are all these useful here?

Let me rephrase: "Which of these are legitimate here?"

The justification for DF here is ensuring that the glyph the user selected in
the dialog is the one that gets inserted. Anything not contributing to that -
should _not_ be inserted. So, looking at:

> * Char Font Char Set
> * Char Font Char Set Asian
> * Char Font Char Set Complex
> * Char Font Family
> * Char Font Family Asian
> * Char Font Family Complex
> * Char Font Name
> * Char Font Name Asian
> * Char Font Name Complex
> * Char Font Pitch
> * Char Font Pitch Asian
> * Char Font Pitch Complex

at most one of each of these triplets is legitimate, the rest aren't (and of
course - it depends on which "language group" each Unicode character is
associated with; I don't like the language group concept but that's a whole
other kettle of fish, bug 151215, comment 19 by Mike also).

So, let's assume we're inserting a character being part of language group LG.
This leaves us with:

* Char Font Char Set LG
* Char Font Family LG
* Char Font Name LG
* Char Font Pitch LG

The first, third, and fourth items here are irrelevant, as we do not choose
them in the dialog: We choose a Unicode character and a font family. So,

* Char Font Char Set LG

(whichever one of the three that might be) is the only legitimate piece of DF
to apply. Applying the rest is a bug.


> 2. Are those that are useful should be always set?

We should let the user decide whether they want to coerce a specific font
family or just insert a character using the same font(s) as the surrounding
text, see bug 155274. That will resolve this question as well.

> Personally I'd prefer to have a special entry in the dialog's font selector,
> like "current font",

That's bug 155274 exactly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to