https://bugs.freedesktop.org/show_bug.cgi?id=61503
Stephan Bergmann <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #17 from Stephan Bergmann <[email protected]> --- I assume this got broken with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4df4e9147019337fda07982c510a85d6f4c4062> "convert cli_ure/source/native to new syntax" (first introduced into libreoffice-4-0) changing the line in to_cli (cli_ure/source/native/native_share.h) from ::System::Runtime::InteropServices::GCHandle handle( ::System::Runtime::InteropServices::GCHandle::op_Explicit( intptr ) ); to ::System::Runtime::InteropServices::GCHandle ^ handle = (::System::Runtime::InteropServices::GCHandle ^)(gcnew ::System::IntPtr(intptr)); With my limited understanding of Managed C++ and .Net, the current state (see comment 16) of ::System::Runtime::InteropServices::GCHandle ^ handle = ::System::Runtime::InteropServices::GCHandle::FromIntPtr(::System::IntPtr(intptr)); reflects the original state again, just going from op_Explicit to FromIntPtr. Whatever exactly the intent of that "convert cli_ure/source/native to new syntax" change was, and whatever the reason the original code used op_Explicit rather than FromIntPtr---maybe because the former is there since .Net Framework 1.0 according to <http://msdn.microsoft.com/en-us/library/awsy2t77.aspx> "GCHandle Explicit Conversion (IntPtr to GCHandle)" while the latter only since .Net Framework 2.0 according to <http://msdn.microsoft.com/en-us/library/system.runtime.interopservices.gchandle.fromintptr.aspx> "GCHandle.FromIntPtr Method," or maybe because the former might save a GCHandle instance instantiation (but my .Net knowledge is too limited there). -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
