https://bugs.documentfoundation.org/show_bug.cgi?id=38844

Hossein <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|reviewed:2022               |reviewed:2023

--- Comment #36 from Hossein <[email protected]> ---
Re-evaluating the EasyHack in 2022

This enhancement is still relevant. I revised the searching for RasterOp::Xor,
excluding those related to emf/wmf, and workbenches. It's around 21 instances,
mostly in vcl:

$ git grep RasterOp::Xor|grep -v wmf|grep -v emf|grep -v workben
drawinglayer/source/processor2d/vclhelperbufferdevice.cxx:    // copy RasterOp
(e.g. may be RasterOp::Xor on destination)
drawinglayer/source/processor2d/vclhelperbufferdevice.cxx:    // during
painting the buffer, disable evtl. set RasterOp (may be RasterOp::Xor)
drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:   
mpOutputDevice->SetRasterOp(RasterOp::Xor);
svx/source/xoutdev/_xoutbmp.cxx:                        pVDev->SetRasterOp(
RasterOp::Xor );
sw/source/uibase/utlui/shdwcrsr.cxx:    m_pWin->GetOutDev()->SetRasterOp(
RasterOp::Xor );
vcl/backendtest/outputdevice/outputdevice.cxx:   
mpVirtualDevice->SetRasterOp(RasterOp::Xor);
vcl/backendtest/outputdevice/outputdevice.cxx:   
mpVirtualDevice->SetRasterOp(RasterOp::Xor);
vcl/backendtest/outputdevice/outputdevice.cxx:   
mpVirtualDevice->SetRasterOp(RasterOp::Xor);
vcl/qa/cppunit/outdev.cxx:    CPPUNIT_ASSERT_EQUAL_MESSAGE("Not an XOR
rasterop", RasterOp::Xor,
vcl/qa/cppunit/outdev.cxx:    CPPUNIT_ASSERT_EQUAL_MESSAGE("Not an XOR
rasterop", RasterOp::Xor,
vcl/qa/cppunit/svm/svmtest.cxx:    pVirtualDev->SetRasterOp(RasterOp::Xor);
vcl/source/filter/imet/ios2met.cxx:        case 0x04: return RasterOp::Xor;
vcl/source/filter/imet/ios2met.cxx:        case 0x0b: return RasterOp::Xor;
vcl/source/filter/ipict/ipict.cxx:            case 2: eActROP=RasterOp::Xor;   
   break; // Xor
vcl/source/filter/ipict/ipict.cxx:            case 6: eActROP=RasterOp::Xor;   
   break; // notXor
vcl/source/filter/svm/SvmConverter.cxx:                        eRasterOp =
RasterOp::Xor;
vcl/source/gdi/mtfxmldump.cxx:        case RasterOp::Xor:       return "xor";
vcl/source/gdi/print.cxx:        mpGraphics->SetXORMode( (RasterOp::Invert ==
meRasterOp) || (RasterOp::Xor == meRasterOp), RasterOp::Invert == meRasterOp );
vcl/source/gdi/virdev.cxx:        mpGraphics->SetXORMode( (RasterOp::Invert ==
meRasterOp) || (RasterOp::Xor == meRasterOp), RasterOp::Invert == meRasterOp );
vcl/source/outdev/gradient.cxx:    SetRasterOp( RasterOp::Xor );
vcl/source/outdev/gradient.cxx:    SetRasterOp( RasterOp::Xor );
vcl/source/outdev/outdev.cxx:            mpGraphics->SetXORMode(
(RasterOp::Invert == meRasterOp) || (RasterOp::Xor == meRasterOp),
RasterOp::Invert == meRasterOp );
vcl/source/window/window.cxx:        mpGraphics->SetXORMode( (RasterOp::Invert
== meRasterOp) || (RasterOp::Xor == meRasterOp), RasterOp::Invert == meRasterOp
);

There are several other instances that may not be directly related, but worth
taking a look:

$ git grep XOR *.cxx|wc -l
237

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to