https://bugs.documentfoundation.org/show_bug.cgi?id=154757

--- Comment #1 from Stephan Bergmann <[email protected]> ---
As I mentioned in the comment at
<https://gerrit.libreoffice.org/c/core/+/152890/2#message-58b2d9892b4fef4e398ed269aa971494ffe1f33d>
"tdf#154757 Provide O(U)String converters for _MESSAGE arguments":  "I think
the main issue here is that as soon as you need a CPPUNIT_ASSERT_MESSAGE with a
programmatically assembled message, your test is doing something wrong anyway. 
:)  Test code should be as straightforward to understand and to debug for
humans as possible.  Tempting as it may be, it ideally should not contain
[e.g.] any loops over data to test, it should rather spell out those individual
tests explicitly.  Probably each of us occasionally is a sinner in this respect
when writing tests, but my argument against such improvements for the
CPPUNIT_ASSERT_MESSAGE's message argument is always the same:  If you need it,
it would be better to restructure the test code (or, failing that, to bite the
bullet and have some explicit call to OUString::getStr or similar, in the 'bad'
test code)."

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to