https://bugs.freedesktop.org/show_bug.cgi?id=63398
--- Comment #7 from Stephan Bergmann <sberg...@redhat.com> --- The UNO "oneway" call concept is documented at <http://web.archive.org/web/20100711070220/http://udk.openoffice.org/common/man/execution.html> "UNO Execution Model" (<http://udk.openoffice.org/common/man/execution.html> appears to have been lost inadvertently). It was only ever translated to asynchronous calls in the case of URP bridge implementations that did not override it to use synchronous calls, and this overriding has ubiquitously been done for ages, first explicitly when setting up bridges and then implicitly in the bridge code itself. That is why it was deemed OK to drop the "oneway" keyword from UNOIDL with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=90eac3e69749a9227c4b6902b1f3cef1e338c6d1> "API CHANGE remove [oneway] method attributes." (And that in turn is the reason why the new TypeDescriptionManager implementation in cppuhelper/source/typemanager.cxx always returns false for isOneway.) What has apparently been overlooked by commit 90eac3e69749a9227c4b6902b1f3cef1e338c6d1 is that there were calls to isOneway that required adaptation and/or could be cleaned up. svxform::FormScriptListener::impl_allowAsynchonousCall_nothrow (svx/source/form/fmscriptingenv.cxx) apparently got added with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=eae0f62d3f3d1c7b8882b3da9fcfc1cdd094c40b> "INTEGRATION: CWS dba205a (1.1.2); FILE ADDED," presumably to fix <https://issues.apache.org/ooo/show_bug.cgi?id=65420> "OO crashes when 'revieve focus' event switches on the Filter Mode." It is unclear to me though why the decision whether to call listeners directly or to postpone that via Application::PostUserEvent should be based on whether the listener method is marked as "oneway." "I have an idea, but the fix is risky, and checks need to be made whether existing macros are affected, so this will be for 2.0.5 only" in <https://issues.apache.org/ooo/show_bug.cgi?id=65420#c10> might be a hint that this was done in an attempt to reduce the risk for regressions. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
