https://bugs.documentfoundation.org/show_bug.cgi?id=93694

Eyal Rozenberg <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|difficultyBeginner,         |
                   |easyHack, skillDesign,      |
                   |topicDesign                 |

--- Comment #17 from Eyal Rozenberg <[email protected]> ---
(In reply to Heiko Tietze from comment #16)

Heiko, you've _mostly_ summarized the result of our discussion; but the bit you
left out is exactly the bit relevant to this bug. Let me explain...


> The functions work well

Ah, but we agreed (at least, I thought we agreed) it does _not_ well - because
it intricates two different functions:

1. Toggling whether or not heading rows repeat
2. Setting which rows are the heading rows

and this is what Yousuf was complaining about: He could not toggle the
repetition under various conditions, even though one should always be able to
make the toggle (at least if at least one header row is defined).

Also, an item whose action depends on the current selection of header rows
can't be named as though it doesn't. i.e. the separate command - would be named
something like "Mark as header rows" or "Set header rows" etc.


> but most of the trouble
> starts with the unconditional placement in the main menu and removing it
> should be a step forward... We agreed on adding to the context menu as an
> acceptable "compensation" for the loss of visibility via the main menu.

Right. But not adding the intricated command, but the toggle

> And we think shorter labels that follow the guidelines are needed too.

Right. But - the short label only makes sense for the separated toggle
functionality

> 
> So in a nutshell:
> 
> Rename 
> + .uno:HeadingRowsRepeat to "Repeat Header Rows"
> + .uno:RowSplit to "Break Row Across Pages"
> => officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
> 
> Remove from main menu
> => sw/uiconfig/*/menubar/menubar.xml
> 
> Add to context menu
> => sw/uiconfig/*/popupmenu/table.xml

So, that's the easy part - but that part does not resolve this particular bug
at all - it only moves things from place to place and renames them.

The functionality split is the bigger deal here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to