https://bugs.documentfoundation.org/show_bug.cgi?id=157638
Bug ID: 157638
Summary: Useless comments of kind //90682 in GraphicImport.cxx
Product: LibreOffice
Version: 24.2.0.0 alpha0+ Master
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: needsDevEval
Severity: normal
Priority: medium
Component: filters and storage
Assignee: [email protected]
Reporter: [email protected]
The file
https://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/GraphicImport.cxx
contains a lot of comments of the kind "// 90650" or "//90682". These comments
are intended to help debugging. They are supposed to contain the numerical
value of NS_ooxml::LN_CT_NonVisualDrawingProps_id or
NS_ooxml::LN_CT_Hyperlink_URL, for example. All of these values in the comments
are outdated and therefor are no longer helpful, but confusing.
I suggest to add a comment, that the values in the comments are outdated and
that the actual numerical values can be found in
workdir/CustomTarget/writerfilter/source/ooxml/resourceids.hxx in the build
directory.
I'm not sure about removing the values in the comments, because that would
affect the history.
Affected are the methods
void GraphicImport::lcl_sprm(Sprm& rSprm)
void GraphicImport::handleWrapTextValue(sal_uInt32 nVal)
void GraphicImport::lcl_attribute(Id nName, Value& rValue)
--
You are receiving this mail because:
You are the assignee for the bug.
