https://bugs.documentfoundation.org/show_bug.cgi?id=157776
BogdanB <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|bibisectRequest |bibisected, bisected CC| |[email protected] | |g, [email protected] --- Comment #2 from BogdanB <[email protected]> --- Mike, I added you here, can you please take a look? 1677cf78d4231960040d91e99c3cf19812aa8e0a is the first bad commit commit 1677cf78d4231960040d91e99c3cf19812aa8e0a Author: Jenkins Build User <[email protected]> Date: Tue Sep 15 06:14:45 2020 +0200 source sha:574eec9036c5f185b3572ba1e0ca9d111eb361dc source sha:574eec9036c5f185b3572ba1e0ca9d111eb361dc instdir/program/libchartcorelo.so | Bin 4552936 -> 4553152 bytes instdir/program/setuprc | 2 +- instdir/program/versionrc | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) author Mike Kaganski <[email protected]> 2020-09-12 17:22:23 +0300 committer Mike Kaganski <[email protected]> 2020-09-15 06:09:04 +0200 commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc (patch) tree 1bb42b53b1b41fbaf87517fb268c08a834d3e0ba parent abcc4eb907661e07ad850ccce7eb06f129da4286 (diff) tdf#77007: chart must honor its parent's IsEnableSetModified Regression from commit bb97ecdbcc8d8dafd39e728b21bc68efee4eccbc, which had dropped storing chart doc (calling its storeOwn) while loading back in 2012, to avoid performance problems when loading XLS. Funnily, in 2013, commit a666862deffa33013d3df3bb62e87c67f9a89948 was merged, that was expected to solve exactly the same problem as this change, by calling storeOwn for charts being loaded; while obviously not fixing the problem properly, it seems to had undone the effect of the Markus's commit. The latter commit had a side effect of updating views of modified charts while exporting them inside storeOwn, which made respective draw pages to be up-to-date right after loading, including those on inactive sheets. Now, after this change, this is not so, thus unit tests' getChartDocFromSheet was made to update the view explicitly. Unfortunately, it's not yet possible to revert the change from commit a666862deffa33013d3df3bb62e87c67f9a89948, because obviously some dependency grew, which makes e.g. testTdf122594 fail if that commit is reverted. Given that testTdf122594 has no charts, storing the modified objects while loading has much wider side effects than was expected by author of a666862deffa33013d3df3bb62e87c67f9a89948. Change-Id: Iee1b9ef6f4d8c2dfa0a49680c5e2b465f1817a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102534 Tested-by: Jenkins Reviewed-by: Mike Kaganski <[email protected]> -- You are receiving this mail because: You are the assignee for the bug.
