https://bugs.documentfoundation.org/show_bug.cgi?id=90664

--- Comment #20 from Julien Nabet <[email protected]> ---
Thank you Armin for your feedback.

When creating a shape without customizing style, LO goes to line 1859:
   1853             // if only one shape with text and no fill or outline is
selected, animate only by first level paragraphs
   1854             if( bHasText && (aTargets.size() == 1) )
   1855             {
   1856                 Reference< XShape > xShape( rTarget, UNO_QUERY );
   1857                 if( xShape.is() && !hasVisibleShape( xShape ) )
   1858                 {
   1859                     mpMainSequence->createTextGroup( pCreated, 1, -1.0,
false, false );
   1860                 }
   1861             }

We depend on hasVisibleShape which contains this:
1059          if( sShapeType == "com.sun.star.presentation.TitleTextShape" ||
sShapeType == "com.sun.star.presentation.OutlinerShape" ||
1060              sShapeType == "com.sun.star.presentation.SubtitleShape" ||
sShapeType == "com.sun.star.drawing.TextShape" )
1061          {
1062              Reference< XPropertySet > xSet( xShape, UNO_QUERY_THROW );
1063  
1064              FillStyle eFillStyle;
1065              xSet->getPropertyValue( "FillStyle" ) >>= eFillStyle;
1066  
1067              css::drawing::LineStyle eLineStyle;
1068              xSet->getPropertyValue( "LineStyle" ) >>= eLineStyle;
1069  
1070              return eFillStyle != FillStyle_NONE || eLineStyle !=
css::drawing::LineStyle_NONE;
1071          }

So when there's no fillstyle and no line style, it returns false and LO calls
createTextGroup.

The pb is once createTextGroup is called, if fillstyle or line style changes,
we can't revert.

I don't know how to test "animate by 1st level paragraph for text shapes by
default" but I suppose reverting would cause some regression.
=> we're stuck here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to