https://bugs.documentfoundation.org/show_bug.cgi?id=158297

ady <adylo811...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisectRequest

--- Comment #10 from ady <adylo811...@gmail.com> ---
(In reply to MBS from comment #9)
> Concerning your description:
> 
> > Until LO 5.2.0.4, the result is (as expected):
> > 
> > Legend;1;2;3
> > b;b-1;b-2;b-3
> > empty;b-1;b-2;b-3
> > d;d-1;d-2;d-3
> > e;e-1;e-2;e-3
> 
> IMHO this is NOT what was to expect (unless "skip empty cells" was ticked),

In older LO versions, there was no "skip empty cells" option in the import text
dialogue. That was the expected result at that time, because that was the way
it worked back then.

For similar reasons, the STR in comment 8 do not include shortcuts or
descriptions of dialogues, but rather a hint of steps that are relatively easy
to follow in whichever version of LO – there are differences in shortcuts, UI
and available options, depending on LO version.


> The "skip empty cells" option allows to fix a target table with new values
> (changed or extending the table) and leave the "good" values in the target
> by pasting empty fields over it, then the former values remain in the target.
> 
> > With these settings in the import dialogue, IMO the result should had been 
> > as it was before, in LO 5.2.0.4 and older.
> I disagree with that.
> 
> It should result in this:
> 
> Legend;1;2;3
> b;b-1;b-2;b-3
> empty;;;
> d;d-1;d-2;d-3
> e;e-1;e-2;e-3
> 
> [skip empty cells]
> btw when the "skip empty cells" option was ticked the result from comment 8
> would be:
> 
> Legend;1;2;3
> b;b-1;b-2;b-3
> empty;b-1;b-2;b-3
> d;d-1;d-2;d-3
> e;e-1;e-2;e-3
> 
> all source cells with values overwrite existing target cells (updating them)
> and empty ones from source will remain untouched in the target.
> Maybe this is the differential replacement you were looking for?

Right.

The tool tip on the "skip empty cells" option says:
  "If enabled, blank cells in source will not override the target."

(For this bug report, I would add an emphasis on the "source" term, and the
fact that the source in this case is not really "cells" until the Text Import
dialogue treats it in such way.)

So, with LO 7.6, the result of the STR from comment 8 should be:

Legend;1;2;3
b;b-1;b-2;b-3
empty;;;
d;d-1;d-2;d-3
e;e-1;e-2;e-3


whereas with the "skip empty cells" option set ON, the result should be:

Legend;1;2;3
b;b-1;b-2;b-3
empty;b-1;b-2;b-3
d;d-1;d-2;d-3
e;e-1;e-2;e-3


Either way, the reported bug is indeed present, and now we are clear about the
_current_ (as of LO 7.6) expected results.

I am still not sure whether this is an "implementation error" or a
"regression".

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to