[Bug 158314] Autofilter dropdown list always shows "Empty" entry as active

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158314

--- Comment #7 from Kevin Suo <suokunl...@126.com> ---
Balázs Varga: Thanks in advance. Below are some FYI.

The problem should be in:
https://opengrok.libreoffice.org/xref/core/sc/source/core/data/column3.cxx?r=8b236923#2587

        if (bIsEmptyCell)
        {
            if (!mrFilterEntries.mbHasEmpties)
            {
                mrFilterEntries.push_back(ScTypedStrData(OUString()));
                mrFilterEntries.mbHasEmpties = true;
            }
            return;
        }

It uses mrFilterEntries.push_back(ScTypedStrData(OUString())), while the
ScTypedStrData() defaults to treat "bIsHiddenByFilter = false", so an empty
entry is always "not hidden by filter".

The same bug may exists for Error cells:

                if (nErr != FormulaError::NONE)
                {
                    // Error cell is evaluated as string (for now).
                    OUString aErr = ScGlobal::GetErrorString(nErr);
                    if (!aErr.isEmpty())
                    {
                       
mrFilterEntries.push_back(ScTypedStrData(std::move(aErr)));
                        return;
                    }

-- 
You are receiving this mail because:
You are the assignee for the bug.