sc/qa/unit/helper/qahelper.hxx | 6 ++++++ 1 file changed, 6 insertions(+)
New commits: commit 09d4dabaea123b8545200244b6c5829115f52bec Author: Tor Lillqvist <tlillqv...@suse.com> Date: Tue Feb 14 13:06:10 2012 +0200 Add comment wondering why this loadFile() isn't in osl diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx index c679c73..0974e70 100644 --- a/sc/qa/unit/helper/qahelper.hxx +++ b/sc/qa/unit/helper/qahelper.hxx @@ -38,6 +38,12 @@ #include <osl/detail/android-bootstrap.h> +// Why is this here and not in osl, and using the already existing file +// handling APIs? Do we really want to add arbitrary new file handling +// wrappers here and there (and then having to handle the Android (and +// eventually perhaps iOS) special cases here, too)? Please move this to osl, +// it sure looks gemerally useful. Or am I missing something? + void loadFile(const rtl::OUString& aFileName, std::string& aContent) { rtl::OString aOFileName = rtl::OUStringToOString(aFileName, RTL_TEXTENCODING_UTF8); _______________________________________________ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits