I'll take a look but it won't be before this weekend. If someone else can check first that would be appreciated (please let me know so I don't duplicate work). If I don't respond by Sunday please poke me again.
Best, Joel On 11/11/2015 03:07 AM, Lionel Elie Mamane wrote: > Hi, > > In the context of tdf#94069 and tdf#95723, the author of the fixes > (not a Base user, thanks for fixing this!) requests checking that his > fix (which just came in, will be in nightlies tomorrow) doesn't break > anything else. > > Any takers? > > Thanks in advance. > > On Wed, Nov 11, 2015 at 10:59:46AM +0000, Caolán McNamara wrote: >> On Fri, 2015-10-30 at 11:31 +0100, Lionel Elie Mamane wrote: >>> Hi, >>> >>> There is patch attached to tdf#94069, nominally a rather annoying >>> Base UI bug (crash!), but which touches the VCL event loop (not >>> specific to Base) in a way that I don't understand the consequences >>> of >> If I look at the behaviour in an older version of LibreOffice pre idle >> tweaking then on moving that widget it "jumps" around a lot and is >> shown rendering in the original location and then the new one and so >> on. So it didn't really work right in the first place as far as I can >> see. >> >> Looking at the UnoControl PushButton etc which don't suffer from this >> problem I see that when setDesignMode is called for everything else >> they set the "real" widget to hidden (it gets drawn via a different >> mechanism than the real Paint in this case) so when its moved around it >> doesn't generate Invalidate events. >> >> So, I think the right solution may be to make the GridControl behave >> like the other UnoControl widgets in that design mode turns off >> visibility. So I've done that as >> a7816853bad55ada597092c16ba9a0a761e067d0 and it seems to work well. >> >> I don't really "use" these things day to day, so testing appreciated >> for this and follow up 44daaebf835bb60fb7e442e928cd30191f15af52 to >> tweak how the grid control is laid out, to ensure I haven't busted >> anything horribly. >> >> C. >> > _______________________________________________ > List Name: Libreoffice-qa mailing list > Mail address: Libreoffice-qa@lists.freedesktop.org > Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa > Problems? > http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ > Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette > List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ _______________________________________________ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/