On Thu, Nov 25, 2010 at 03:33:08AM -0700, Tor Lillqvist <tlillqv...@novell.com> 
wrote:
> Sure, although I think I would prefer to keep OSL_THIS_FUNC as ""
> instead of "(unknown)" in the fallback case.

OK, I just changed that and pushed it.

> So, you think the i#114290 argument that neither __PRETTY_FUNCTION__
> nor __func__ can be used because neither is a string literal and thus
> can't be compile-time concatenated with other string literals is
> bogus?

Yes, to my understanding.

> As such, it is true of course that they can't be used like that. But
> is the proper solution then just to not try to use OSL_THIS_FUNC in
> that way? Instead just pass it as a separate argument to printf (yeah,
> my C background shows through) or whatever?

I think, so. At least my use-case is like this:

OSL_TRACE("%s: unhandled segment '%x' in the path", OSL_THIS_FUNC, nSeg);

Attachment: pgppjBFQvIrgz.pgp
Description: PGP signature

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to