On Tue, 2011-01-25 at 18:45 +0100, Kenneth Venken wrote: > Hi, > > these patches solve some of the 'redundant assignment to self' > warnings.
Looks good. Thanks for these, all pushed. re: 0001-Cpp-cleanliness-redundant-assignment-to-s.components.patch, I suppose we could catch those exceptions by const reference in general, but I generally don't bother myself either. re: 0001-Cpp-cleanliness-redundant-assignment-to-self.ure.patch, FWIW for those parameter used in one ifdef vs another personally I typically stick (void) parameter in the #else branch to silence the compiler and cppcheck and friends. re: 0001-Cpp-cleanliness-redundant-assignment-to-se.libs-core.patch looking at that, the whole nPos thing seems useless as far as I can see and we can remove it completely. Did that additionally as well re: 0001-Cpp-cleanliness-redundant-assignment-to-sel.libs-gui.patch, this is a good one, clear bug since 2001. A very good catch. For it to have remained undiscovered this code must never be called. I'll see if we can remove it entirely. C. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
