On Fri, Mar 25, 2011 at 08:48:25PM +0000, Michael Meeks <michael.me...@novell.com> wrote: > Looks lovely to me - though I guess it might be nice to just pick a > large number for RET_APPLY and not put that in vcl; that seems to be > how others do it eg. > > sfx2/inc/docvor.hxx:#define RET_EDIT_STYLE 100 > sfx2/inc/sfx2/new.hxx:#define RET_TEMPLATE_LOAD 100 > > etc. if we want to clean this up - we should add a: > > #define RET_CUSTOM_START 100 > > or something, to the vcl header, and then use that (I think)
Ah, I didn't see it. We talked about this with Cedric and he explained an idea which avoids any modification in vcl, so I'm not planning to push this version, a better one will come soon. The main problem is not with the modification, but if you move the dialog, click Apply, then its position will be reset, which is ugly. > > Also, I can change the indentation in sw/source/ui/app/docst.cxx, I > > didn't do it yet for easier review. > .. > > What's your opinion, OK to push? > > With the above tweak I'm enthusiastic - nice patch ! :-) but ... why > are you (Mr Awesome) doing 'easy' hacks ? :-) I guess for each one you > fix, you need to research & create one more ;-> Partly because of GSoC - it's listed on the wiki page that students should solve one before applying. Partly as this touches GUI code - which I never did before, so it amuses me. :)
pgpEVajRcfwnv.pgp
Description: PGP signature
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
