Hi guys,
I see quite a staggering number of these things around the codebase:
$ g grep '== sal_True' | wc -l
744
and the (less dangerous IMHO) '== sal_False' construct has ~400 (what
positive people we are ;-)
if( m_pDataContainer->IsModuleInstalled( E_SWRITER ) == sal_True )
if( IsModified() == sal_True )
if( m_bOwner == sal_True )
etc. etc.
sal_True is -1 - which is great for unsigned bit fields and all that -
but - well, I am certain there are a whole host of creative errors
around where a supposedly boolean value is neither 0 nor -1, and of
course these create serious trouble were we to convert to using plain
'bool' more widely.
The question is - are others concerned about this, and/or should we
have a (very) easy hack to fix it ?
Thoughts ?
Michael.
--
[email protected] <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
