Hi Michael, On Sat, May 07, 2011 at 07:41:38PM +0100, Michael Meeks wrote: > > On Sat, 2011-05-07 at 17:41 +0200, Francois Tigeot wrote: > > The attached patch removes most of the obsolete file system-related enums > > in libs-gui and keeps only two "styles": > > Nice :-) We should be using URLs everywhere but in the lowest levels, > or platform specific pieces (I hope).
As long as the implementation is sane; I also removed FSYS_STYLE_URL stuff. > > If there is no objection, I'll push this patch in a few days > > The cleanup is great of course. It is well worth checking, before each > piece of fixing inside tools/ itself, whether we can save more time by > re-writing the (sometimes rather few) call-sites, to use sal/ classes > instead (?) :-) It would be best; many methods were already unused and DirEntry screams to be removed from the tree. Howewer, since I lack knowledge of the different APIs, I'm only doing this sort of incremental cleaning for now. > Usually the sal API is far lamer in its semantic richness, so > potentially expanding and improving sal at the same time can be a useful > thing to do. It's best to keep it lame IMHO. The code I cleaned was trying to do too many things which were utterly irrelevant... Thanks for your encouragement ! -- Francois Tigeot _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
