Hi there, On Fri, 2011-07-15 at 00:55 +0200, Markus Mohrhard wrote: > So one review needed to get it into 3.4.2. It is an quite important > fix as we got several reports where people reported they thought that > calc froze and switched back to 3.3.2.
So: git diff --numstat 0_5_2..0_5_3 # inside mdds shows: 9 1 include/mdds/mixed_type_matrix.hpp 22 3 include/mdds/mixed_type_matrix_def.inl 113 652 include/mdds/mixed_type_matrix_storage.hpp 701 0 include/mdds/mixed_type_matrix_storage_filled_linear.inl 374 0 include/mdds/mixed_type_matrix_storage_filled_nested_array.inl 376 0 include/mdds/mixed_type_matrix_storage_sparse.inl 2 244 include/mdds/rectangle_set.hpp 274 0 include/mdds/rectangle_set_def.inl 2 2 misc/mdds.spec.in 11 0 multidimalgorithm.vpj 81 0 src/array_creation_perf_test.cpp 75 8 src/mixed_type_matrix_test.cpp 1 0 src/test_global.hpp I feel extremely uncomfortable (personally) introducing a couple of thousands of LOC change between RC1 and final for 3.4.2. We're in a triple review mode because our changes will not get much testing before they are unleashed on tens of thousands of new people per day. I'd prefer to see this slip into 3.4.3 (personally) - shame if the problem is there, but the chance of regression seems high - even though the code is nice and clean of course :-) HTH, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice