On Fri, 2015-03-27 at 09:34 +0200, Noel Grandin wrote: > Hi > > So I started looking at converting the WinBits WB_* defines in > > include/tools/wintypes.hxx > > to an 'enum class', and after a few changes and discovering that there are > lots of WB_ macros scattered around that > simply define a new WB_ value as pointing to an existing one e.g. in > > include/svtools/ivctrl.hxx > #define WB_ICON WB_RECTSTYLE > #define WB_SMALLICON WB_SMALLSTYLE > > , I think that this whole thing needs a rethink. > > Specifically, I think that > > (*) we need to push these style things down to the subclass-specific level > where each one applies, instead of > multiplexing them into a single field at the root level
Yeah, ideally that'd be the case. There are almost certainly bugs in here already with different overlapping WB_ from different logical groups getting or-ed together so it'll probably be a bit of a pain to unpick. C. _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
