On Sat, Aug 13, 2011 at 3:58 PM, Lionel Elie Mamane <[email protected]> wrote: > On Sat, Aug 13, 2011 at 03:43:36PM -0500, Norbert Thiebaud wrote: >> On Sat, Aug 13, 2011 at 2:26 PM, Lionel Elie Mamane <[email protected]> wrote: > >>> If ./download is run twice: > >>> - the first time it creates e.g. symlink ure connectivity -> >>> clone/libs-core/connectivity > >> there is no clone/libs-core anymore on master... > > The example was taken from a libreoffice-3.4 branch. > >>> - the second time it creates a symlink named connectivity/connectivity >>> (thus clone/libs-core/connectivity/connectivity) pointing to >>> clone/libs-core/connectivity, that is pointing to >>> >>> ROOT_OF_SOURCE_TREE/clone/libs-core/connectivity/clone/libs-core/connectivity >>> . > >>> That second symlink is not what was intended and is a dangling >>> symlink. The attached patch fixes that, telling ln to always create >>> the symlink as named on the command line, and to never implicitly >>> create a symlink named after the target in the directory named on the >>> command line. > >> -T is not a portable option of ln, iow your patch would break MacOS >> build. > > Good point. FreeBSD, MacOS X and GNU ld all support option "-n", which > is sufficient for this particular need. So new version of patch > attached.
Pushed, thanks. Norbert > > -- > Lionel > _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
