On Aug 25, 2011, at 11:00 PM, Lionel Elie Mamane wrote:
> On Thu, Aug 25, 2011 at 10:10:16PM +0200, Stephan Bergmann wrote:
>> On Aug 25, 2011, at 6:09 PM, Lionel Elie Mamane wrote:
>>> On Tue, Aug 23, 2011 at 07:37:06PM +0200, Stephan Bergmann wrote:
>>>> On Aug 23, 2011, at 5:00 PM, Lionel Elie Mamane wrote:
> 
>> - There is no reason for OPropertySetHelper2 to have a non-virtual
>> dtor.  (And thus no reason to disable warnings.)
> 
> Why does OPropertySetHelper have a non-virtual dtor, actually?

A historic mistake (that could not be corrected without breaking compatibility).

>> - The OPropertySetHelper::queryInterface symbol must not be removed
>>  from gcc3.map.
> 
> It was there in duplicate, I remove it only once. It is right there,
> three lines up from the one removed.

Ah, missed that.

>> - For the question of which symbols for OPropertySetHelper2 to list
>>  in the various map files, see
>>  <http://udk.openoffice.org/common/man/apicppclasses.html> (you
>>  probably need access to builds on the various platforms to find
>>  out the correct mangled names).
> 
> OK, thanks will read. As to "access to builds on the various
> platforms", that's rather optimistic…

Yes, sure.  As Michael already wrote, modus operandi is that somebody with 
access to any given platform helps out.

-Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to