On 09/23/2015 07:39 AM, Takeshi Abe wrote:
commit 5ca4acf877834c51d896268cf3dd390903b2248b Author: Takeshi Abe <[email protected]> Date: Wed Sep 23 06:03:55 2015 +0900starmath: Prefix members of SmErrorDesc Change-Id: I4910561e3671f546f2e36344016e2b50fd2a70eb Reviewed-on: https://gerrit.libreoffice.org/18788 Tested-by: Jenkins <[email protected]> Reviewed-by: Miklos Vajna <[email protected]> diff --git a/starmath/inc/error.hxx b/starmath/inc/error.hxx index 7794a4a..99a2245 100644 --- a/starmath/inc/error.hxx +++ b/starmath/inc/error.hxx @@ -41,9 +41,9 @@ enum SmParseError struct SmErrorDesc { - SmParseError Type; - SmNode *pNode; - OUString Text; + SmParseError m_eType; + SmNode *m_pNode; + OUString m_aText; }; #endif
Just a small remark: With "plain" structs that only contain (public, non-static) member variables and no member functions, it often makes sense to not decorate the member variable names.
As there are no member functions, there is never any ambiguity whether use of a name denotes a member or local variable, and accessing the member variables "from the outside" typically reads more natural as
desc->pNode than as desc->m_pNode _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
