hi Maxim, On 11.11.2015 14:04, Maxim Monastirsky wrote: > New commits: > commit a133053f94f7c5b05f4354bb4977c2250b470a8a > Author: Maxim Monastirsky <[email protected]> > Date: Wed Nov 11 15:01:52 2015 +0200 > > tdf#93837 Create Thesaurus popup menu controller > > The old context menu implementation adds the thesaurus > sub-menu by manipulating the menu at runtime, which isn't a > good idea in general. Since it's a sub-menu anyway, better > to have it as a separate controller, so it can be added > to the xml, and users could decide if they want it, and > where. > > Most of the code adapted from sfx2 (menu/mnumgr.cxx, > menu/thessubmenu.cxx), hence the Apache-based license > header.
as it happens my clang plugin just pointed me to the global variable SfxPopupMenuManager::pStaticThesSubMenu - which is just *unbelievably* ugly; it even has its own bug report at https://bz.apache.org/ooo/show_bug.cgi?id=107205 i hope this new way to add the Thesaurus menu entry allows for removing pStaticThesSubMenu sometime soon? _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
