On 28.06.2016 18:28, Michael Meeks wrote: > Hi Mohammed, > > Let me CC the dev list on the fag-end of this conversation; hopefully > it will get more interesting over time =) > > On Mon, 2016-06-27 at 22:01 +0530, Mohammed Abdul Azeem wrote: >> I'm looking into the code paths which misuses defined namespaces >> without resolving them. I will make test cases to cover them. > > Ah - right =) > >> Sure we can do this, but it would only account for element's namespace >> and not attributes namespaces. Also some of the implementations of >> XDocumentHandler expects namespace declaration( looking for "xmlns" ) >> and tries to resolve them, and I think this approach wouldn't cover >> all the namespace declaration. > > Ah ! fair enough - then (I guess) we need to implement a new > XFastNamespaceHandler which we can register with a setNamespaceHandler() > call on XFastParser - and which can be NULL for all the interesting > cases where we need to be truly fast =) > > Then (I guess) we could pass namespace prefixed names through for the > unknown attributes so eg. "office:foo" - and still have the information > we need to properly resolve them.
uhm... how many bad comparisons like "if (attribute == "office:foo") exist? a quick git grep finds only a handful, mostly in base code - wouldn't it be easier to just fix those? _______________________________________________ LibreOffice mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice
