Remember that char is either signed or unsigned, depending on
platform. Sure, char being signed is the much more common thing, but
for instance on ARM Linuxes it is unsigned. So code like:

char nDiff = bDown ? 1 : -1;
...
if( (-1 == nDiff && 0 >= nLevel) ||
     (1 == nDiff && MAXLEVEL - 1 <= nLevel))

is wrong. nDiff will never be -1.

One more reason to always build with --enable-werror.

--tml
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to