basegfx/source/matrix/b3dhommatrix.cxx | 11 +++++++++++ basegfx/source/polygon/b3dpolygon.cxx | 11 +++++++++++ basegfx/source/tools/b2dclipstate.cxx | 10 ++++++++++ drawinglayer/source/attribute/fillgradientattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/fillhatchattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/fontattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/sdrfillattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/sdrfillgraphicattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/sdrlightingattribute3d.cxx | 5 +++++ drawinglayer/source/attribute/sdrlinestartendattribute.cxx | 11 +++++++++++ drawinglayer/source/attribute/sdrsceneattribute3d.cxx | 11 +++++++++++ drawinglayer/source/attribute/sdrshadowattribute.cxx | 11 +++++++++++ drawinglayer/source/geometry/viewinformation2d.cxx | 11 +++++++++++ drawinglayer/source/geometry/viewinformation3d.cxx | 11 +++++++++++ include/basegfx/matrix/b3dhommatrix.hxx | 2 ++ include/basegfx/polygon/b3dpolygon.hxx | 2 ++ include/basegfx/tools/b2dclipstate.hxx | 2 ++ include/drawinglayer/attribute/fillgradientattribute.hxx | 2 ++ include/drawinglayer/attribute/fillhatchattribute.hxx | 2 ++ include/drawinglayer/attribute/fontattribute.hxx | 2 ++ include/drawinglayer/attribute/sdrfillattribute.hxx | 2 ++ include/drawinglayer/attribute/sdrfillgraphicattribute.hxx | 2 ++ include/drawinglayer/attribute/sdrlightingattribute3d.hxx | 2 ++ include/drawinglayer/attribute/sdrlinestartendattribute.hxx | 2 ++ include/drawinglayer/attribute/sdrsceneattribute3d.hxx | 2 ++ include/drawinglayer/attribute/sdrshadowattribute.hxx | 2 ++ include/drawinglayer/geometry/viewinformation2d.hxx | 3 +++ include/drawinglayer/geometry/viewinformation3d.hxx | 3 +++ 28 files changed, 177 insertions(+)
New commits: commit b9ab0dd3e5eb3c948ee9a29006637e48d5751a5e Author: Noel Grandin <[email protected]> Date: Thu Aug 25 13:16:54 2016 +0200 cid#1371276 Missing move assignment operator also cid#1371234, cid#1371249, cid#1371208, cid#1371250, cid#1371258, cid#1371266, cid#1371257, cid#1371221 Change-Id: I18d952887b684e1999d003cec0f668789c851b52 diff --git a/basegfx/source/tools/b2dclipstate.cxx b/basegfx/source/tools/b2dclipstate.cxx index d4bc4fa..84e8e2c 100644 --- a/basegfx/source/tools/b2dclipstate.cxx +++ b/basegfx/source/tools/b2dclipstate.cxx @@ -393,6 +393,10 @@ namespace tools mpImpl(rOrig.mpImpl) {} + B2DClipState::B2DClipState( B2DClipState&& rOrig ) : + mpImpl(std::move(rOrig.mpImpl)) + {} + B2DClipState::B2DClipState( const B2DPolyPolygon& rPolyPoly ) : mpImpl( ImplB2DClipState(rPolyPoly) ) {} @@ -403,6 +407,12 @@ namespace tools return *this; } + B2DClipState& B2DClipState::operator=( B2DClipState&& rRHS ) + { + mpImpl = std::move(rRHS.mpImpl); + return *this; + } + void B2DClipState::makeNull() { mpImpl->makeNull(); diff --git a/drawinglayer/source/attribute/fillgradientattribute.cxx b/drawinglayer/source/attribute/fillgradientattribute.cxx index 5cc76e3..941f311 100644 --- a/drawinglayer/source/attribute/fillgradientattribute.cxx +++ b/drawinglayer/source/attribute/fillgradientattribute.cxx @@ -124,6 +124,11 @@ namespace drawinglayer { } + FillGradientAttribute::FillGradientAttribute(FillGradientAttribute&& rCandidate) + : mpFillGradientAttribute(std::move(rCandidate.mpFillGradientAttribute)) + { + } + FillGradientAttribute::~FillGradientAttribute() { } @@ -139,6 +144,12 @@ namespace drawinglayer return *this; } + FillGradientAttribute& FillGradientAttribute::operator=(FillGradientAttribute&& rCandidate) + { + mpFillGradientAttribute = std::move(rCandidate.mpFillGradientAttribute); + return *this; + } + bool FillGradientAttribute::operator==(const FillGradientAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/drawinglayer/source/attribute/fontattribute.cxx b/drawinglayer/source/attribute/fontattribute.cxx index 20d743d..95a4ef7 100644 --- a/drawinglayer/source/attribute/fontattribute.cxx +++ b/drawinglayer/source/attribute/fontattribute.cxx @@ -140,6 +140,11 @@ namespace drawinglayer { } + FontAttribute::FontAttribute(FontAttribute&& rCandidate) + : mpFontAttribute(std::move(rCandidate.mpFontAttribute)) + { + } + FontAttribute::~FontAttribute() { } @@ -150,6 +155,12 @@ namespace drawinglayer return *this; } + FontAttribute& FontAttribute::operator=(FontAttribute&& rCandidate) + { + mpFontAttribute = std::move(rCandidate.mpFontAttribute); + return *this; + } + bool FontAttribute::operator==(const FontAttribute& rCandidate) const { return rCandidate.mpFontAttribute == mpFontAttribute; diff --git a/drawinglayer/source/attribute/sdrfillattribute.cxx b/drawinglayer/source/attribute/sdrfillattribute.cxx index 422f3eb..003f0a3 100644 --- a/drawinglayer/source/attribute/sdrfillattribute.cxx +++ b/drawinglayer/source/attribute/sdrfillattribute.cxx @@ -108,6 +108,11 @@ namespace drawinglayer { } + SdrFillAttribute::SdrFillAttribute(SdrFillAttribute&& rCandidate) + : mpSdrFillAttribute(std::move(rCandidate.mpSdrFillAttribute)) + { + } + SdrFillAttribute::~SdrFillAttribute() { } @@ -123,6 +128,12 @@ namespace drawinglayer return *this; } + SdrFillAttribute& SdrFillAttribute::operator=(SdrFillAttribute&& rCandidate) + { + mpSdrFillAttribute = std::move(rCandidate.mpSdrFillAttribute); + return *this; + } + bool SdrFillAttribute::operator==(const SdrFillAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/drawinglayer/source/attribute/sdrfillgraphicattribute.cxx b/drawinglayer/source/attribute/sdrfillgraphicattribute.cxx index 816519d..0d68143 100644 --- a/drawinglayer/source/attribute/sdrfillgraphicattribute.cxx +++ b/drawinglayer/source/attribute/sdrfillgraphicattribute.cxx @@ -143,6 +143,11 @@ namespace drawinglayer { } + SdrFillGraphicAttribute::SdrFillGraphicAttribute(SdrFillGraphicAttribute&& rCandidate) + : mpSdrFillGraphicAttribute(std::move(rCandidate.mpSdrFillGraphicAttribute)) + { + } + SdrFillGraphicAttribute::~SdrFillGraphicAttribute() { } @@ -158,6 +163,12 @@ namespace drawinglayer return *this; } + SdrFillGraphicAttribute& SdrFillGraphicAttribute::operator=(SdrFillGraphicAttribute&& rCandidate) + { + mpSdrFillGraphicAttribute = std::move(rCandidate.mpSdrFillGraphicAttribute); + return *this; + } + bool SdrFillGraphicAttribute::operator==(const SdrFillGraphicAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/drawinglayer/source/attribute/sdrsceneattribute3d.cxx b/drawinglayer/source/attribute/sdrsceneattribute3d.cxx index 1580a51..2f0ce70 100644 --- a/drawinglayer/source/attribute/sdrsceneattribute3d.cxx +++ b/drawinglayer/source/attribute/sdrsceneattribute3d.cxx @@ -105,6 +105,11 @@ namespace drawinglayer { } + SdrSceneAttribute::SdrSceneAttribute(SdrSceneAttribute&& rCandidate) + : mpSdrSceneAttribute(std::move(rCandidate.mpSdrSceneAttribute)) + { + } + SdrSceneAttribute::~SdrSceneAttribute() { } @@ -120,6 +125,12 @@ namespace drawinglayer return *this; } + SdrSceneAttribute& SdrSceneAttribute::operator=(SdrSceneAttribute&& rCandidate) + { + mpSdrSceneAttribute = std::move(rCandidate.mpSdrSceneAttribute); + return *this; + } + bool SdrSceneAttribute::operator==(const SdrSceneAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/drawinglayer/source/attribute/sdrshadowattribute.cxx b/drawinglayer/source/attribute/sdrshadowattribute.cxx index 4a938fd..41f834f 100644 --- a/drawinglayer/source/attribute/sdrshadowattribute.cxx +++ b/drawinglayer/source/attribute/sdrshadowattribute.cxx @@ -91,6 +91,11 @@ namespace drawinglayer { } + SdrShadowAttribute::SdrShadowAttribute(SdrShadowAttribute&& rCandidate) + : mpSdrShadowAttribute(std::move(rCandidate.mpSdrShadowAttribute)) + { + } + SdrShadowAttribute::~SdrShadowAttribute() { } @@ -106,6 +111,12 @@ namespace drawinglayer return *this; } + SdrShadowAttribute& SdrShadowAttribute::operator=(SdrShadowAttribute&& rCandidate) + { + mpSdrShadowAttribute = std::move(rCandidate.mpSdrShadowAttribute); + return *this; + } + bool SdrShadowAttribute::operator==(const SdrShadowAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/drawinglayer/source/geometry/viewinformation2d.cxx b/drawinglayer/source/geometry/viewinformation2d.cxx index ca7daf6..a50a8f0 100644 --- a/drawinglayer/source/geometry/viewinformation2d.cxx +++ b/drawinglayer/source/geometry/viewinformation2d.cxx @@ -433,6 +433,11 @@ namespace drawinglayer { } + ViewInformation2D::ViewInformation2D(ViewInformation2D&& rCandidate) + : mpViewInformation2D(std::move(rCandidate.mpViewInformation2D)) + { + } + ViewInformation2D::~ViewInformation2D() { } @@ -443,6 +448,12 @@ namespace drawinglayer return *this; } + ViewInformation2D& ViewInformation2D::operator=(ViewInformation2D&& rCandidate) + { + mpViewInformation2D = std::move(rCandidate.mpViewInformation2D); + return *this; + } + bool ViewInformation2D::operator==(const ViewInformation2D& rCandidate) const { return rCandidate.mpViewInformation2D == mpViewInformation2D; diff --git a/drawinglayer/source/geometry/viewinformation3d.cxx b/drawinglayer/source/geometry/viewinformation3d.cxx index 19dd802..1e6693c 100644 --- a/drawinglayer/source/geometry/viewinformation3d.cxx +++ b/drawinglayer/source/geometry/viewinformation3d.cxx @@ -456,6 +456,11 @@ namespace drawinglayer { } + ViewInformation3D::ViewInformation3D(ViewInformation3D&& rCandidate) + : mpViewInformation3D(std::move(rCandidate.mpViewInformation3D)) + { + } + ViewInformation3D::~ViewInformation3D() { } @@ -471,6 +476,12 @@ namespace drawinglayer return *this; } + ViewInformation3D& ViewInformation3D::operator=(ViewInformation3D&& rCandidate) + { + mpViewInformation3D = std::move(rCandidate.mpViewInformation3D); + return *this; + } + bool ViewInformation3D::operator==(const ViewInformation3D& rCandidate) const { return rCandidate.mpViewInformation3D == mpViewInformation3D; diff --git a/include/basegfx/tools/b2dclipstate.hxx b/include/basegfx/tools/b2dclipstate.hxx index bd57a12..dab598e 100644 --- a/include/basegfx/tools/b2dclipstate.hxx +++ b/include/basegfx/tools/b2dclipstate.hxx @@ -59,8 +59,10 @@ namespace basegfx B2DClipState(); ~B2DClipState(); B2DClipState( const B2DClipState& ); + B2DClipState( B2DClipState&& ); explicit B2DClipState( const B2DPolyPolygon& ); B2DClipState& operator=( const B2DClipState& ); + B2DClipState& operator=( B2DClipState&& ); /// Set clip to 'null' - nothing is visible void makeNull(); diff --git a/include/drawinglayer/attribute/fillgradientattribute.hxx b/include/drawinglayer/attribute/fillgradientattribute.hxx index a6f98f6..7355b6b 100644 --- a/include/drawinglayer/attribute/fillgradientattribute.hxx +++ b/include/drawinglayer/attribute/fillgradientattribute.hxx @@ -77,7 +77,9 @@ namespace drawinglayer sal_uInt16 nSteps); FillGradientAttribute(); FillGradientAttribute(const FillGradientAttribute& rCandidate); + FillGradientAttribute(FillGradientAttribute&& rCandidate); FillGradientAttribute& operator=(const FillGradientAttribute& rCandidate); + FillGradientAttribute& operator=(FillGradientAttribute&& rCandidate); ~FillGradientAttribute(); // checks if the incarnation is default constructed diff --git a/include/drawinglayer/attribute/fontattribute.hxx b/include/drawinglayer/attribute/fontattribute.hxx index 1b35189..5b2e791 100644 --- a/include/drawinglayer/attribute/fontattribute.hxx +++ b/include/drawinglayer/attribute/fontattribute.hxx @@ -68,7 +68,9 @@ namespace drawinglayer bool bBiDiStrong = false); FontAttribute(); FontAttribute(const FontAttribute& rCandidate); + FontAttribute(FontAttribute&& rCandidate); FontAttribute& operator=(const FontAttribute& rCandidate); + FontAttribute& operator=(FontAttribute&& rCandidate); ~FontAttribute(); // compare operator diff --git a/include/drawinglayer/attribute/sdrfillattribute.hxx b/include/drawinglayer/attribute/sdrfillattribute.hxx index 4349547..cb71257 100644 --- a/include/drawinglayer/attribute/sdrfillattribute.hxx +++ b/include/drawinglayer/attribute/sdrfillattribute.hxx @@ -60,7 +60,9 @@ namespace drawinglayer const SdrFillGraphicAttribute& rFillGraphic); SdrFillAttribute(); SdrFillAttribute(const SdrFillAttribute& rCandidate); + SdrFillAttribute(SdrFillAttribute&& rCandidate); SdrFillAttribute& operator=(const SdrFillAttribute& rCandidate); + SdrFillAttribute& operator=(SdrFillAttribute&& rCandidate); ~SdrFillAttribute(); // checks if the incarnation is default constructed diff --git a/include/drawinglayer/attribute/sdrfillgraphicattribute.hxx b/include/drawinglayer/attribute/sdrfillgraphicattribute.hxx index b3163a5..2531fb0 100644 --- a/include/drawinglayer/attribute/sdrfillgraphicattribute.hxx +++ b/include/drawinglayer/attribute/sdrfillgraphicattribute.hxx @@ -64,7 +64,9 @@ namespace drawinglayer bool bLogSize); SdrFillGraphicAttribute(); SdrFillGraphicAttribute(const SdrFillGraphicAttribute& rCandidate); + SdrFillGraphicAttribute(SdrFillGraphicAttribute&& rCandidate); SdrFillGraphicAttribute& operator=(const SdrFillGraphicAttribute& rCandidate); + SdrFillGraphicAttribute& operator=(SdrFillGraphicAttribute&& rCandidate); ~SdrFillGraphicAttribute(); // checks if the incarnation is default constructed diff --git a/include/drawinglayer/attribute/sdrsceneattribute3d.hxx b/include/drawinglayer/attribute/sdrsceneattribute3d.hxx index bdd0edf..e25ed77 100644 --- a/include/drawinglayer/attribute/sdrsceneattribute3d.hxx +++ b/include/drawinglayer/attribute/sdrsceneattribute3d.hxx @@ -56,7 +56,9 @@ namespace drawinglayer bool bTwoSidedLighting); SdrSceneAttribute(); SdrSceneAttribute(const SdrSceneAttribute& rCandidate); + SdrSceneAttribute(SdrSceneAttribute&& rCandidate); SdrSceneAttribute& operator=(const SdrSceneAttribute& rCandidate); + SdrSceneAttribute& operator=(SdrSceneAttribute&& rCandidate); ~SdrSceneAttribute(); // checks if the incarnation is default constructed diff --git a/include/drawinglayer/attribute/sdrshadowattribute.hxx b/include/drawinglayer/attribute/sdrshadowattribute.hxx index d92110d..2bb7c13 100644 --- a/include/drawinglayer/attribute/sdrshadowattribute.hxx +++ b/include/drawinglayer/attribute/sdrshadowattribute.hxx @@ -56,7 +56,9 @@ namespace drawinglayer const basegfx::BColor& rColor); SdrShadowAttribute(); SdrShadowAttribute(const SdrShadowAttribute& rCandidate); + SdrShadowAttribute(SdrShadowAttribute&& rCandidate); SdrShadowAttribute& operator=(const SdrShadowAttribute& rCandidate); + SdrShadowAttribute& operator=(SdrShadowAttribute&& rCandidate); ~SdrShadowAttribute(); // checks if the incarnation is default constructed diff --git a/include/drawinglayer/geometry/viewinformation2d.hxx b/include/drawinglayer/geometry/viewinformation2d.hxx index cb76998..08ec259 100644 --- a/include/drawinglayer/geometry/viewinformation2d.hxx +++ b/include/drawinglayer/geometry/viewinformation2d.hxx @@ -114,11 +114,14 @@ namespace drawinglayer /// copy constructor ViewInformation2D(const ViewInformation2D& rCandidate); + ViewInformation2D(ViewInformation2D&& rCandidate); + /// destructor ~ViewInformation2D(); /// assignment operator ViewInformation2D& operator=(const ViewInformation2D& rCandidate); + ViewInformation2D& operator=(ViewInformation2D&& rCandidate); /// compare operators bool operator==(const ViewInformation2D& rCandidate) const; diff --git a/include/drawinglayer/geometry/viewinformation3d.hxx b/include/drawinglayer/geometry/viewinformation3d.hxx index e35d0bf..4d2f826 100644 --- a/include/drawinglayer/geometry/viewinformation3d.hxx +++ b/include/drawinglayer/geometry/viewinformation3d.hxx @@ -119,6 +119,8 @@ namespace drawinglayer /// copy constructor ViewInformation3D(const ViewInformation3D& rCandidate); + ViewInformation3D(ViewInformation3D&& rCandidate); + /// destructor ~ViewInformation3D(); @@ -127,6 +129,7 @@ namespace drawinglayer /// assignment operator ViewInformation3D& operator=(const ViewInformation3D& rCandidate); + ViewInformation3D& operator=(ViewInformation3D&& rCandidate); /// compare operators bool operator==(const ViewInformation3D& rCandidate) const; commit 3d8154789bca1f5a0901859e23bf5e4b458af1ff Author: Noel Grandin <[email protected]> Date: Thu Aug 25 13:14:46 2016 +0200 cid#1371277 Missing move assignment operator Change-Id: Ic737733f5951d5b21660a12a7a01202bd9bc303c diff --git a/drawinglayer/source/attribute/sdrlightingattribute3d.cxx b/drawinglayer/source/attribute/sdrlightingattribute3d.cxx index d500943..67f5037 100644 --- a/drawinglayer/source/attribute/sdrlightingattribute3d.cxx +++ b/drawinglayer/source/attribute/sdrlightingattribute3d.cxx @@ -84,6 +84,11 @@ namespace drawinglayer { } + SdrLightingAttribute::SdrLightingAttribute(SdrLightingAttribute&& rCandidate) + : mpSdrLightingAttribute(std::move(rCandidate.mpSdrLightingAttribute)) + { + } + SdrLightingAttribute::~SdrLightingAttribute() { } diff --git a/include/drawinglayer/attribute/sdrlightingattribute3d.hxx b/include/drawinglayer/attribute/sdrlightingattribute3d.hxx index 70e0e45..5fa40db 100644 --- a/include/drawinglayer/attribute/sdrlightingattribute3d.hxx +++ b/include/drawinglayer/attribute/sdrlightingattribute3d.hxx @@ -58,7 +58,9 @@ namespace drawinglayer const ::std::vector< Sdr3DLightAttribute >& rLightVector); SdrLightingAttribute(); SdrLightingAttribute(const SdrLightingAttribute& rCandidate); + SdrLightingAttribute(SdrLightingAttribute&& rCandidate); SdrLightingAttribute& operator=(const SdrLightingAttribute& rCandidate); + SdrLightingAttribute& operator=(SdrLightingAttribute&& rCandidate); ~SdrLightingAttribute(); // checks if the incarnation is default constructed commit 69a5e1e562f7859a1c9745d578cd936a330b9aad Author: Noel Grandin <[email protected]> Date: Thu Aug 25 13:10:29 2016 +0200 cid#1371281 Missing move assignment operator Change-Id: I29e1b042d2550bbe909ea432b161bdcb418d8976 diff --git a/basegfx/source/polygon/b3dpolygon.cxx b/basegfx/source/polygon/b3dpolygon.cxx index 1841943..517cb97 100644 --- a/basegfx/source/polygon/b3dpolygon.cxx +++ b/basegfx/source/polygon/b3dpolygon.cxx @@ -1508,6 +1508,11 @@ namespace basegfx { } + B3DPolygon::B3DPolygon(B3DPolygon&& rPolygon) : + mpPolygon(std::move(rPolygon.mpPolygon)) + { + } + B3DPolygon::~B3DPolygon() { } @@ -1518,6 +1523,12 @@ namespace basegfx return *this; } + B3DPolygon& B3DPolygon::operator=(B3DPolygon&& rPolygon) + { + mpPolygon = std::move(rPolygon.mpPolygon); + return *this; + } + bool B3DPolygon::operator==(const B3DPolygon& rPolygon) const { if(mpPolygon.same_object(rPolygon.mpPolygon)) diff --git a/include/basegfx/polygon/b3dpolygon.hxx b/include/basegfx/polygon/b3dpolygon.hxx index d32968b..7657627 100644 --- a/include/basegfx/polygon/b3dpolygon.hxx +++ b/include/basegfx/polygon/b3dpolygon.hxx @@ -51,10 +51,12 @@ namespace basegfx public: B3DPolygon(); B3DPolygon(const B3DPolygon& rPolygon); + B3DPolygon(B3DPolygon&& rPolygon); ~B3DPolygon(); // assignment operator B3DPolygon& operator=(const B3DPolygon& rPolygon); + B3DPolygon& operator=(B3DPolygon&& rPolygon); // compare operators bool operator==(const B3DPolygon& rPolygon) const; commit cff0edb0b874986886e5c98ca077bda640059a83 Author: Noel Grandin <[email protected]> Date: Thu Aug 25 13:03:47 2016 +0200 cid#1371284 Missing move assignment operator Change-Id: I84d4cfe58f9659b468a1fd62b7974fcdbf0bb1f3 diff --git a/drawinglayer/source/attribute/sdrlinestartendattribute.cxx b/drawinglayer/source/attribute/sdrlinestartendattribute.cxx index b70aa18..c133bf95 100644 --- a/drawinglayer/source/attribute/sdrlinestartendattribute.cxx +++ b/drawinglayer/source/attribute/sdrlinestartendattribute.cxx @@ -126,6 +126,11 @@ namespace drawinglayer { } + SdrLineStartEndAttribute::SdrLineStartEndAttribute(SdrLineStartEndAttribute&& rCandidate) + : mpSdrLineStartEndAttribute(std::move(rCandidate.mpSdrLineStartEndAttribute)) + { + } + SdrLineStartEndAttribute::~SdrLineStartEndAttribute() { } @@ -141,6 +146,12 @@ namespace drawinglayer return *this; } + SdrLineStartEndAttribute& SdrLineStartEndAttribute::operator=(SdrLineStartEndAttribute&& rCandidate) + { + mpSdrLineStartEndAttribute = std::move(rCandidate.mpSdrLineStartEndAttribute); + return *this; + } + bool SdrLineStartEndAttribute::operator==(const SdrLineStartEndAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/include/drawinglayer/attribute/sdrlinestartendattribute.hxx b/include/drawinglayer/attribute/sdrlinestartendattribute.hxx index d56a265..e89e748 100644 --- a/include/drawinglayer/attribute/sdrlinestartendattribute.hxx +++ b/include/drawinglayer/attribute/sdrlinestartendattribute.hxx @@ -60,7 +60,9 @@ namespace drawinglayer bool bEndCentered); SdrLineStartEndAttribute(); SdrLineStartEndAttribute(const SdrLineStartEndAttribute& rCandidate); + SdrLineStartEndAttribute(SdrLineStartEndAttribute&& rCandidate); SdrLineStartEndAttribute& operator=(const SdrLineStartEndAttribute& rCandidate); + SdrLineStartEndAttribute& operator=(SdrLineStartEndAttribute&& rCandidate); ~SdrLineStartEndAttribute(); // checks if the incarnation is default constructed commit 781fdb676fc89789180181e1ff2800df82c4c851 Author: Noel Grandin <[email protected]> Date: Thu Aug 25 13:01:25 2016 +0200 cid#1371285 Missing move assignment operator Change-Id: Ia822a01caec28f8137e30c05b6904c9fac367ce4 diff --git a/basegfx/source/matrix/b3dhommatrix.cxx b/basegfx/source/matrix/b3dhommatrix.cxx index 2d017dd..26fbcce 100644 --- a/basegfx/source/matrix/b3dhommatrix.cxx +++ b/basegfx/source/matrix/b3dhommatrix.cxx @@ -42,6 +42,11 @@ namespace basegfx { } + B3DHomMatrix::B3DHomMatrix(B3DHomMatrix&& rMat) : + mpImpl(std::move(rMat.mpImpl)) + { + } + B3DHomMatrix::~B3DHomMatrix() { } @@ -52,6 +57,12 @@ namespace basegfx return *this; } + B3DHomMatrix& B3DHomMatrix::operator=(B3DHomMatrix&& rMat) + { + mpImpl = std::move(rMat.mpImpl); + return *this; + } + double B3DHomMatrix::get(sal_uInt16 nRow, sal_uInt16 nColumn) const { return mpImpl->get(nRow, nColumn); diff --git a/include/basegfx/matrix/b3dhommatrix.hxx b/include/basegfx/matrix/b3dhommatrix.hxx index ec8ee34..20f02f0 100644 --- a/include/basegfx/matrix/b3dhommatrix.hxx +++ b/include/basegfx/matrix/b3dhommatrix.hxx @@ -42,6 +42,7 @@ namespace basegfx public: B3DHomMatrix(); B3DHomMatrix(const B3DHomMatrix& rMat); + B3DHomMatrix(B3DHomMatrix&& rMat); ~B3DHomMatrix(); double get(sal_uInt16 nRow, sal_uInt16 nColumn) const; @@ -107,6 +108,7 @@ namespace basegfx // assignment operator B3DHomMatrix& operator=(const B3DHomMatrix& rMat); + B3DHomMatrix& operator=(B3DHomMatrix&& rMat); // decomposition bool decompose(B3DTuple& rScale, B3DTuple& rTranslate, B3DTuple& rRotate, B3DTuple& rShear) const; commit 877dfa3783316c4c2850b0e5bd3837765d7c12c2 Author: Noel Grandin <[email protected]> Date: Thu Aug 25 12:58:57 2016 +0200 cid#1371288 Missing move assignment operator Change-Id: I5181c76f558e1806de01f21422c715cc93f3cb3d diff --git a/drawinglayer/source/attribute/fillhatchattribute.cxx b/drawinglayer/source/attribute/fillhatchattribute.cxx index e55e1f7..fef4cdf 100644 --- a/drawinglayer/source/attribute/fillhatchattribute.cxx +++ b/drawinglayer/source/attribute/fillhatchattribute.cxx @@ -113,6 +113,11 @@ namespace drawinglayer { } + FillHatchAttribute::FillHatchAttribute(FillHatchAttribute&& rCandidate) + : mpFillHatchAttribute(std::move(rCandidate.mpFillHatchAttribute)) + { + } + FillHatchAttribute::~FillHatchAttribute() { } @@ -128,6 +133,12 @@ namespace drawinglayer return *this; } + FillHatchAttribute& FillHatchAttribute::operator=(FillHatchAttribute&& rCandidate) + { + mpFillHatchAttribute = std::move(rCandidate.mpFillHatchAttribute); + return *this; + } + bool FillHatchAttribute::operator==(const FillHatchAttribute& rCandidate) const { // tdf#87509 default attr is always != non-default attr, even with same values diff --git a/include/drawinglayer/attribute/fillhatchattribute.hxx b/include/drawinglayer/attribute/fillhatchattribute.hxx index 40e350a..1d08d60 100644 --- a/include/drawinglayer/attribute/fillhatchattribute.hxx +++ b/include/drawinglayer/attribute/fillhatchattribute.hxx @@ -72,7 +72,9 @@ namespace drawinglayer bool bFillBackground); FillHatchAttribute(); FillHatchAttribute(const FillHatchAttribute& rCandidate); + FillHatchAttribute(FillHatchAttribute&& rCandidate); FillHatchAttribute& operator=(const FillHatchAttribute& rCandidate); + FillHatchAttribute& operator=(FillHatchAttribute&& rCandidate); ~FillHatchAttribute(); // checks if the incarnation is default constructed _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
