slaka wrote

We are only failing 3 individual tests. And we fail the same tests Excel
fails. Instead of disabling all test for x86 Linux , why not disable or
change the rounding accuracy of the individual tests?


LO only seems to have problems only with numbers very close to approaching 1 i.e. 0.999999999999999

The results LO gives for 0.000000000000001 through to .99999999 appear to be consistent with what the Keisan online calculator returns at http://keisan.casio.com/exec/system/1180573197.

Personally I would either

1. change the expected result to match what LO now returns;
2. change the number so that it is not so close to 1 i.e. something
   like 0.999999
3. introduce another test with a number approaching 0 i.e.
   0.000000000000001

Alex



On 14/09/16 23:06, slacka wrote:
Eike Rathke-2 wrote
If you want to get a working build without disabling all checks then you
can use
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b9a27d5856f60688456762bfcc29c38670009254

that disables the function tests for linux_x86 builds.

However, if you'd find a general solution that does not involve
disabling the tests that would be more than welcomed.

   Eike
We are only failing 3 individual tests. And we fail the same tests Excel
fails. Instead of disabling all test for x86 Linux , why not disable or
change the rounding accuracy of the individual tests?

For example, CHIINV can be made to work with both x86, x86-64 and Excel by
changing
C8=ROUND(A8,3)=ROUND(B8,3)
VDS can be made to work with x86, x86-64, and Excel by changing
C11=ROUND(A11,10)=ROUND(B11,10)

MINVERSE x86 and Excel get similar results. Unless there is some evidences
we have the same bug in our x86 code as Excel, the test is invalid or the
bug is with the x86-64 code. So shouldn’t we disable that individual test?



Eike Rathke-2 wrote
So you actually *do* see it. Or only not in chiinv.fods?
Sorry I was not clear. MINVERSE is the first test to fail on my AMD desktop.
CHIINV does fail but only when I run it manually. I assume the tests are not
run sequentially. Are they? If they are something weird is going on and I
can try disabling MINVERSE and VDS to see if that's enough for a successful
build.





--
View this message in context: 
http://nabble.documentfoundation.org/Test-File-sc-qa-unit-data-functions-fods-chiinv-fods-fails-with-Assertion-tp4192267p4193577.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to