loolwsd/LOOLProtocol.hpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
New commits: commit a4290ec4da0afb0c845bd2552689cab0fbbb018b Author: Tor Lillqvist <[email protected]> Date: Mon Sep 26 10:12:48 2016 +0300 Add FIXME comment diff --git a/loolwsd/LOOLProtocol.hpp b/loolwsd/LOOLProtocol.hpp index f239bca..c7c42e1 100644 --- a/loolwsd/LOOLProtocol.hpp +++ b/loolwsd/LOOLProtocol.hpp @@ -85,8 +85,13 @@ namespace LOOLProtocol inline bool tokenIndicatesUserInteraction(const std::string& token) { - // Exclude tokens that include these keywords, - // such as canceltiles statusindicator. + // Exclude tokens that include these keywords, such as canceltiles statusindicator. + + // FIXME: This is wrong. That the token happens to contain (or not) a certain substring is + // no guarantee that it "indicates user interaction". It might be like that at the moment, + // but that is coincidental. We should check what the actual whole token is, at least, not + // look for a substring. + return (token.find("tile") == std::string::npos && token.find("status") == std::string::npos && token.find("state") == std::string::npos); _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
