[Libreoffice-commits] core.git: 2 commits - sc/qa vcl/inc vcl/unx

[Caolán McNamara]

 sc/qa/unit/tiledrendering/tiledrendering.cxx |    1 +
 vcl/inc/unx/saldisp.hxx                      |    1 -
 vcl/unx/generic/app/saldisp.cxx              |    8 --------
 3 files changed, 1 insertion(+), 9 deletions(-)

New commits:
commit bb43a23036dcfda114368441c5aa82a9a90355cd
Author: Caolán McNamara <caol...@redhat.com>
Date:   Mon Oct 3 09:26:54 2016 +0100

    coverity#1373353 Uninitialized scalar field
    
    Change-Id: Ifc65e3fbc2dd076f322482459f4ad96745f64882

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 9fdefb5..63175fe 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -390,6 +390,7 @@ public:
         : m_bOwnCursorInvalidated(false),
           m_bViewCursorInvalidated(false),
           m_bTextViewSelectionInvalidated(false),
+          m_bGraphicSelection(false),
           m_bGraphicViewSelection(false),
           m_bFullInvalidateTiles(false),
           m_bViewLock(false)
commit d8b8ddf372c980f8c7d1ad66ae439d2ce60b82ba
Author: Caolán McNamara <caol...@redhat.com>
Date:   Sat Oct 1 21:26:13 2016 +0100

    custom dtor is unnecessary
    
    Change-Id: I2b9d167628995747a6c1b032f3461d988ed485e5

diff --git a/vcl/inc/unx/saldisp.hxx b/vcl/inc/unx/saldisp.hxx
index ee651b6..f4d2b23 100644
--- a/vcl/inc/unx/saldisp.hxx
+++ b/vcl/inc/unx/saldisp.hxx
@@ -120,7 +120,6 @@ public:
                  SalX11Screen       nXScreen );
     SalColormap( sal_uInt16         nDepth );
     SalColormap();
-    ~SalColormap();
 
     inline  Colormap            GetXColormap() const { return m_hColormap; }
     inline  const SalDisplay*   GetDisplay() const { return m_pDisplay; }
diff --git a/vcl/unx/generic/app/saldisp.cxx b/vcl/unx/generic/app/saldisp.cxx
index ed1fb53..3cb7cec 100644
--- a/vcl/unx/generic/app/saldisp.cxx
+++ b/vcl/unx/generic/app/saldisp.cxx
@@ -2705,14 +2705,6 @@ SalColormap::SalColormap( sal_uInt16 nDepth )
     }
 }
 
-SalColormap::~SalColormap()
-{
-#ifdef DBG_UTIL
-    m_hColormap      = None;
-    m_pDisplay       = nullptr;
-#endif
-}
-
 void SalColormap::GetPalette()
 {
     Pixel i;

_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits