On 10/11/2016 09:48 AM, Stephan Bergmann wrote:
On 10/10/2016 10:24 PM, Eike Rathke wrote:
I'd rather say it's a bug when assigning the involved OUStringBuffer
(here aLCIDString) to itself again.. so for clarification:

https://gerrit.libreoffice.org/#/c/28666/5 had

    aLCIDString = "[$-" + aLCIDString + "]";
    aFormatStr.insert( nPosInsertLCID, aLCIDString.toString() );

which produced an erroneous "[$-[$-[$-0]"

Ouch.  Would probably make sense to forbid that O[U]StringBuffer takes
part in such concatenations (by removing the
ToStringHelper<O[U]StringBfufer> specializations, which are luckily
LIBO_INTERNAL_ONLY).  I'll look into that.

<https://cgit.freedesktop.org/libreoffice/core/commit/?id=802f2a420859f6787c86a960aa331245423d5820> "Don't allow O[U]StringBuffer in string concatenation"

LibreOffice mailing list

Reply via email to