sc/inc/scabstdlg.hxx | 68 +++++++++++++++++------------------
sc/source/ui/attrdlg/scdlgfact.cxx | 66 +++++++++++++++++-----------------
sc/source/ui/attrdlg/scdlgfact.hxx | 70 ++++++++++++++++++-------------------
3 files changed, 102 insertions(+), 102 deletions(-)
New commits:
commit 927df8bff2f6a95f5a829aa142b5a05b3a96e35f
Author: Noel Grandin <n...@peralex.com>
Date: Mon Oct 31 10:08:01 2016 +0200
return dialog pointers using VclPtr<>
or their ref-count could drop to zero before they actually get used
Change-Id: I5af7a0cc8650e3d779c870144c23b6de19c8cc45
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 7961787..bfbd5ad 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -398,36 +398,36 @@ public:
SvStream*
pInStream,
ScImportAsciiCall eCall) = 0;
- virtual AbstractScTextImportOptionsDlg *
CreateScTextImportOptionsDlg() = 0;
+ virtual VclPtr<AbstractScTextImportOptionsDlg>
CreateScTextImportOptionsDlg() = 0;
- virtual AbstractScAutoFormatDlg * CreateScAutoFormatDlg(vcl::Window*
pParent,
+ virtual VclPtr<AbstractScAutoFormatDlg>
CreateScAutoFormatDlg(vcl::Window* pParent,
ScAutoFormat*
pAutoFormat,
const
ScAutoFormatData* pSelFormatData,
ScViewData
*pViewData) = 0;
- virtual AbstractScColRowLabelDlg * CreateScColRowLabelDlg (vcl::Window*
pParent,
+ virtual VclPtr<AbstractScColRowLabelDlg> CreateScColRowLabelDlg
(vcl::Window* pParent,
bool bCol,
bool bRow =
false) = 0;
- virtual AbstractScSortWarningDlg * CreateScSortWarningDlg(vcl::Window*
pParent, const OUString& rExtendText, const OUString& rCurrentText ) = 0;
+ virtual VclPtr<AbstractScSortWarningDlg>
CreateScSortWarningDlg(vcl::Window* pParent, const OUString& rExtendText, const
OUString& rCurrentText ) = 0;
- virtual AbstractScCondFormatManagerDlg*
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const
ScConditionalFormatList* pFormatList ) = 0;
+ virtual VclPtr<AbstractScCondFormatManagerDlg>
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const
ScConditionalFormatList* pFormatList ) = 0;
- virtual AbstractScDataPilotDatabaseDlg *
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) = 0;
+ virtual VclPtr<AbstractScDataPilotDatabaseDlg>
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) = 0;
- virtual AbstractScDataPilotSourceTypeDlg *
CreateScDataPilotSourceTypeDlg(vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataPilotSourceTypeDlg>
CreateScDataPilotSourceTypeDlg(vcl::Window* pParent,
bool bEnableExternal) = 0;
- virtual AbstractScDataPilotServiceDlg * CreateScDataPilotServiceDlg(
vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataPilotServiceDlg> CreateScDataPilotServiceDlg(
vcl::Window* pParent,
const
std::vector<OUString>& rServices ) = 0;
- virtual AbstractScDeleteCellDlg * CreateScDeleteCellDlg(vcl::Window*
pParent, bool bDisallowCellMove) = 0 ;
+ virtual VclPtr<AbstractScDeleteCellDlg> CreateScDeleteCellDlg(vcl::Window*
pParent, bool bDisallowCellMove) = 0 ;
//for dataform
- virtual AbstractScDataFormDlg * CreateScDataFormDlg(vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataFormDlg> CreateScDataFormDlg(vcl::Window*
pParent,
ScTabViewShell* pTabViewShell) = 0;
- virtual AbstractScDeleteContentsDlg *
CreateScDeleteContentsDlg(vcl::Window* pParent) = 0;
- virtual AbstractScFillSeriesDlg * CreateScFillSeriesDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDeleteContentsDlg>
CreateScDeleteContentsDlg(vcl::Window* pParent) = 0;
+ virtual VclPtr<AbstractScFillSeriesDlg> CreateScFillSeriesDlg(
vcl::Window* pParent,
ScDocument&
rDocument,
FillDir
eFillDir,
FillCmd
eFillCmd,
@@ -437,23 +437,23 @@ public:
double
fMax,
sal_uInt16
nPossDir) = 0;
- virtual AbstractScGroupDlg * CreateAbstractScGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScGroupDlg> CreateAbstractScGroupDlg( vcl::Window*
pParent,
bool bUnGroup =
false ) = 0;
- virtual AbstractScInsertCellDlg * CreateScInsertCellDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScInsertCellDlg> CreateScInsertCellDlg(
vcl::Window* pParent,
bool
bDisallowCellMove ) = 0;
- virtual AbstractScInsertContentsDlg * CreateScInsertContentsDlg(
vcl::Window* pParent,
+ virtual VclPtr<AbstractScInsertContentsDlg> CreateScInsertContentsDlg(
vcl::Window* pParent,
const
OUString* pStrTitle = nullptr ) = 0;
- virtual AbstractScInsertTableDlg * CreateScInsertTableDlg(vcl::Window*
pParent, ScViewData& rViewData,
+ virtual VclPtr<AbstractScInsertTableDlg>
CreateScInsertTableDlg(vcl::Window* pParent, ScViewData& rViewData,
SCTAB nTabCount, bool bFromFile) = 0;
- virtual AbstractScSelEntryDlg * CreateScSelEntryDlg ( vcl::Window* pParent,
+ virtual VclPtr<AbstractScSelEntryDlg > CreateScSelEntryDlg ( vcl::Window*
pParent,
const
std::vector<OUString> &rEntryList ) = 0;
- virtual AbstractScLinkedAreaDlg * CreateScLinkedAreaDlg(vcl::Window*
pParent) = 0;
+ virtual VclPtr<AbstractScLinkedAreaDlg> CreateScLinkedAreaDlg(vcl::Window*
pParent) = 0;
- virtual AbstractScMetricInputDlg * CreateScMetricInputDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScMetricInputDlg> CreateScMetricInputDlg (
vcl::Window* pParent,
const OString&
sDialogName,
long
nCurrent,
long
nDefault,
@@ -462,56 +462,56 @@ public:
long
nMaximum = 1000,
long
nMinimum = 0 ) = 0;
- virtual AbstractScMoveTableDlg * CreateScMoveTableDlg(vcl::Window *
pParent,
+ virtual VclPtr<AbstractScMoveTableDlg> CreateScMoveTableDlg(vcl::Window *
pParent,
const OUString& rDefault) = 0;
- virtual AbstractScNameCreateDlg * CreateScNameCreateDlg(vcl::Window *
pParent,
+ virtual VclPtr<AbstractScNameCreateDlg> CreateScNameCreateDlg(vcl::Window
* pParent,
sal_uInt16 nFlags) = 0;
- virtual AbstractScNamePasteDlg * CreateScNamePasteDlg ( vcl::Window *
pParent, ScDocShell* pShell, bool bInsList=true ) = 0;
+ virtual VclPtr<AbstractScNamePasteDlg> CreateScNamePasteDlg ( vcl::Window
* pParent, ScDocShell* pShell, bool bInsList=true ) = 0;
- virtual AbstractScPivotFilterDlg * CreateScPivotFilterDlg(vcl::Window*
pParent,
+ virtual VclPtr<AbstractScPivotFilterDlg>
CreateScPivotFilterDlg(vcl::Window* pParent,
const SfxItemSet& rArgSet, sal_uInt16 nSourceTab) = 0;
- virtual AbstractScDPFunctionDlg * CreateScDPFunctionDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPFunctionDlg> CreateScDPFunctionDlg(
vcl::Window* pParent,
const
ScDPLabelDataVector& rLabelVec,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData ) = 0;
- virtual AbstractScDPSubtotalDlg * CreateScDPSubtotalDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPSubtotalDlg> CreateScDPSubtotalDlg(
vcl::Window* pParent,
ScDPObject&
rDPObj,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData,
const
ScDPNameVec& rDataFields ) = 0;
- virtual AbstractScDPNumGroupDlg * CreateScDPNumGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPNumGroupDlg> CreateScDPNumGroupDlg(
vcl::Window* pParent,
const
ScDPNumGroupInfo& rInfo ) = 0;
- virtual AbstractScDPDateGroupDlg * CreateScDPDateGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPDateGroupDlg> CreateScDPDateGroupDlg(
vcl::Window* pParent,
const
ScDPNumGroupInfo& rInfo,
sal_Int32
nDatePart,
const Date&
rNullDate ) = 0;
- virtual AbstractScDPShowDetailDlg * CreateScDPShowDetailDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPShowDetailDlg> CreateScDPShowDetailDlg(
vcl::Window* pParent,
ScDPObject&
rDPObj,
sal_uInt16
nOrient ) = 0;
- virtual AbstractScNewScenarioDlg * CreateScNewScenarioDlg ( vcl::Window*
pParent, const OUString& rName,
+ virtual VclPtr<AbstractScNewScenarioDlg> CreateScNewScenarioDlg (
vcl::Window* pParent, const OUString& rName,
bool bEdit,
bool bSheetProtected = false ) = 0;
- virtual AbstractScShowTabDlg * CreateScShowTabDlg(vcl::Window* pParent) =
0;
+ virtual VclPtr<AbstractScShowTabDlg> CreateScShowTabDlg(vcl::Window*
pParent) = 0;
- virtual AbstractScStringInputDlg * CreateScStringInputDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScStringInputDlg> CreateScStringInputDlg (
vcl::Window* pParent,
const
OUString& rTitle,
const
OUString& rEditTitle,
const
OUString& rDefault,
const OString&
sHelpId, const OString& sEditHelpId ) = 0;
- virtual AbstractScTabBgColorDlg * CreateScTabBgColorDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScTabBgColorDlg> CreateScTabBgColorDlg (
vcl::Window* pParent,
const
OUString& rTitle, //Dialog Title
const
OUString& rTabBgColorNoColorText, //Label for no tab color
const Color&
rDefaultColor ) = 0; //Currently selected Color
- virtual AbstractScImportOptionsDlg * CreateScImportOptionsDlg ( bool
bAscii,
+ virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool
bAscii,
const
ScImportOptions* pOptions = nullptr,
const
OUString* pStrTitle = nullptr,
bool
bMultiByte = false,
@@ -543,7 +543,7 @@ public:
virtual VclPtr<SfxAbstractTabDialog> CreateScSortDlg(vcl::Window* pParent,
const SfxItemSet* pArgSet) = 0;
// for tabpage
- virtual CreateTabPage GetTabPageCreatorFunc( sal_uInt16 nId
) = 0;
+ virtual CreateTabPage GetTabPageCreatorFunc( sal_uInt16 nId
) = 0;
protected:
~ScAbstractDialogFactory() {}
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx
b/sc/source/ui/attrdlg/scdlgfact.cxx
index 9344693..be4d216 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -604,13 +604,13 @@ VclPtr<AbstractScImportAsciiDlg>
ScAbstractDialogFactory_Impl::CreateScImportAsc
return VclPtr<AbstractScImportAsciiDlg_Impl>::Create( pDlg );
}
-AbstractScTextImportOptionsDlg *
ScAbstractDialogFactory_Impl::CreateScTextImportOptionsDlg()
+VclPtr<AbstractScTextImportOptionsDlg>
ScAbstractDialogFactory_Impl::CreateScTextImportOptionsDlg()
{
VclPtr<ScTextImportOptionsDlg> pDlg =
VclPtr<ScTextImportOptionsDlg>::Create(nullptr);
return VclPtr<AbstractScTextImportOptionsDlg_Impl>::Create(pDlg);
}
-AbstractScAutoFormatDlg *
ScAbstractDialogFactory_Impl::CreateScAutoFormatDlg(vcl::Window* pParent,
+VclPtr<AbstractScAutoFormatDlg>
ScAbstractDialogFactory_Impl::CreateScAutoFormatDlg(vcl::Window* pParent,
ScAutoFormat*
pAutoFormat,
const
ScAutoFormatData* pSelFormatData,
ScViewData
*pViewData)
@@ -619,7 +619,7 @@ AbstractScAutoFormatDlg *
ScAbstractDialogFactory_Impl::CreateScAutoFormatDlg(vc
return VclPtr<AbstractScAutoFormatDlg_Impl>::Create(pDlg);
}
-AbstractScColRowLabelDlg *
ScAbstractDialogFactory_Impl::CreateScColRowLabelDlg(vcl::Window* pParent,
+VclPtr<AbstractScColRowLabelDlg>
ScAbstractDialogFactory_Impl::CreateScColRowLabelDlg(vcl::Window* pParent,
bool bCol ,
bool bRow)
{
@@ -627,59 +627,59 @@ AbstractScColRowLabelDlg *
ScAbstractDialogFactory_Impl::CreateScColRowLabelDlg
return VclPtr<AbstractScColRowLabelDlg_Impl>::Create( pDlg );
}
-AbstractScSortWarningDlg*
ScAbstractDialogFactory_Impl::CreateScSortWarningDlg( vcl::Window* pParent,
const OUString& rExtendText, const OUString& rCurrentText )
+VclPtr<AbstractScSortWarningDlg>
ScAbstractDialogFactory_Impl::CreateScSortWarningDlg( vcl::Window* pParent,
const OUString& rExtendText, const OUString& rCurrentText )
{
VclPtr<ScSortWarningDlg> pDlg = VclPtr<ScSortWarningDlg>::Create(pParent,
rExtendText, rCurrentText );
return VclPtr<AbstractScSortWarningDlg_Impl>::Create( pDlg );
}
-AbstractScCondFormatManagerDlg*
ScAbstractDialogFactory_Impl::CreateScCondFormatMgrDlg(vcl::Window* pParent,
ScDocument* pDoc, const ScConditionalFormatList* pFormatList )
+VclPtr<AbstractScCondFormatManagerDlg>
ScAbstractDialogFactory_Impl::CreateScCondFormatMgrDlg(vcl::Window* pParent,
ScDocument* pDoc, const ScConditionalFormatList* pFormatList )
{
VclPtr<ScCondFormatManagerDlg> pDlg =
VclPtr<ScCondFormatManagerDlg>::Create( pParent, pDoc, pFormatList );
return VclPtr<AbstractScCondFormatManagerDlg_Impl>::Create( pDlg );
}
-AbstractScDataPilotDatabaseDlg *
ScAbstractDialogFactory_Impl::CreateScDataPilotDatabaseDlg(vcl::Window* pParent)
+VclPtr<AbstractScDataPilotDatabaseDlg>
ScAbstractDialogFactory_Impl::CreateScDataPilotDatabaseDlg(vcl::Window* pParent)
{
VclPtr<ScDataPilotDatabaseDlg> pDlg =
VclPtr<ScDataPilotDatabaseDlg>::Create( pParent );
return VclPtr<AbstractScDataPilotDatabaseDlg_Impl>::Create( pDlg );
}
-AbstractScDataPilotSourceTypeDlg*
ScAbstractDialogFactory_Impl::CreateScDataPilotSourceTypeDlg(
+VclPtr<AbstractScDataPilotSourceTypeDlg>
ScAbstractDialogFactory_Impl::CreateScDataPilotSourceTypeDlg(
vcl::Window* pParent, bool bEnableExternal)
{
VclPtr<ScDataPilotSourceTypeDlg> pDlg =
VclPtr<ScDataPilotSourceTypeDlg>::Create(pParent, bEnableExternal);
return VclPtr<AbstractScDataPilotSourceTypeDlg_Impl>::Create(pDlg);
}
-AbstractScDataPilotServiceDlg*
ScAbstractDialogFactory_Impl::CreateScDataPilotServiceDlg( vcl::Window* pParent,
+VclPtr<AbstractScDataPilotServiceDlg>
ScAbstractDialogFactory_Impl::CreateScDataPilotServiceDlg( vcl::Window* pParent,
const
std::vector<OUString>& rServices )
{
VclPtr<ScDataPilotServiceDlg> pDlg =
VclPtr<ScDataPilotServiceDlg>::Create( pParent, rServices );
return VclPtr<AbstractScDataPilotServiceDlg_Impl>::Create( pDlg );
}
-AbstractScDeleteCellDlg*
ScAbstractDialogFactory_Impl::CreateScDeleteCellDlg(vcl::Window* pParent,
+VclPtr<AbstractScDeleteCellDlg>
ScAbstractDialogFactory_Impl::CreateScDeleteCellDlg(vcl::Window* pParent,
bool bDisallowCellMove)
{
VclPtr<ScDeleteCellDlg> pDlg = VclPtr<ScDeleteCellDlg>::Create(pParent,
bDisallowCellMove);
return VclPtr<AbstractScDeleteCellDlg_Impl>::Create( pDlg );
}
-AbstractScDataFormDlg*
ScAbstractDialogFactory_Impl::CreateScDataFormDlg(vcl::Window* pParent,
+VclPtr<AbstractScDataFormDlg>
ScAbstractDialogFactory_Impl::CreateScDataFormDlg(vcl::Window* pParent,
ScTabViewShell* pTabViewShell)
{
VclPtr<ScDataFormDlg> pDlg = VclPtr<ScDataFormDlg>::Create(pParent,
pTabViewShell);
return VclPtr<AbstractScDataFormDlg_Impl>::Create(pDlg);
}
-AbstractScDeleteContentsDlg*
ScAbstractDialogFactory_Impl::CreateScDeleteContentsDlg(vcl::Window* pParent)
+VclPtr<AbstractScDeleteContentsDlg>
ScAbstractDialogFactory_Impl::CreateScDeleteContentsDlg(vcl::Window* pParent)
{
VclPtr<ScDeleteContentsDlg> pDlg =
VclPtr<ScDeleteContentsDlg>::Create(pParent, InsertDeleteFlags::NONE);
return VclPtr<AbstractScDeleteContentsDlg_Impl>::Create( pDlg );
}
-AbstractScFillSeriesDlg* ScAbstractDialogFactory_Impl::CreateScFillSeriesDlg(
vcl::Window* pParent,
+VclPtr<AbstractScFillSeriesDlg>
ScAbstractDialogFactory_Impl::CreateScFillSeriesDlg( vcl::Window* pParent,
ScDocument&
rDocument,
FillDir
eFillDir,
FillCmd
eFillCmd,
@@ -693,48 +693,48 @@ AbstractScFillSeriesDlg*
ScAbstractDialogFactory_Impl::CreateScFillSeriesDlg( vc
return VclPtr<AbstractScFillSeriesDlg_Impl>::Create( pDlg );
}
-AbstractScGroupDlg* ScAbstractDialogFactory_Impl::CreateAbstractScGroupDlg(
vcl::Window* pParent,
+VclPtr<AbstractScGroupDlg>
ScAbstractDialogFactory_Impl::CreateAbstractScGroupDlg( vcl::Window* pParent,
bool bUnGroup )
{
VclPtr<ScGroupDlg> pDlg = VclPtr<ScGroupDlg>::Create( pParent, bUnGroup,
true/*bRows*/);
return VclPtr<AbstractScGroupDlg_Impl>::Create( pDlg );
}
-AbstractScInsertCellDlg * ScAbstractDialogFactory_Impl::CreateScInsertCellDlg(
vcl::Window* pParent,
+VclPtr<AbstractScInsertCellDlg>
ScAbstractDialogFactory_Impl::CreateScInsertCellDlg( vcl::Window* pParent,
bool
bDisallowCellMove )
{
VclPtr<ScInsertCellDlg> pDlg = VclPtr<ScInsertCellDlg>::Create( pParent,
bDisallowCellMove);
return VclPtr<AbstractScInsertCellDlg_Impl>::Create( pDlg );
}
-AbstractScInsertContentsDlg *
ScAbstractDialogFactory_Impl::CreateScInsertContentsDlg( vcl::Window*
pParent,
+VclPtr<AbstractScInsertContentsDlg>
ScAbstractDialogFactory_Impl::CreateScInsertContentsDlg( vcl::Window*
pParent,
const OUString* pStrTitle )
{
VclPtr<ScInsertContentsDlg> pDlg =
VclPtr<ScInsertContentsDlg>::Create(pParent, InsertDeleteFlags::NONE,
pStrTitle);
return VclPtr<AbstractScInsertContentsDlg_Impl>::Create( pDlg );
}
-AbstractScInsertTableDlg *
ScAbstractDialogFactory_Impl::CreateScInsertTableDlg(vcl::Window* pParent,
ScViewData& rViewData,
+VclPtr<AbstractScInsertTableDlg>
ScAbstractDialogFactory_Impl::CreateScInsertTableDlg(vcl::Window* pParent,
ScViewData& rViewData,
SCTAB nTabCount, bool bFromFile)
{
VclPtr<ScInsertTableDlg> pDlg = VclPtr<ScInsertTableDlg>::Create( pParent,
rViewData,nTabCount, bFromFile );
return VclPtr<AbstractScInsertTableDlg_Impl>::Create( pDlg );
}
-AbstractScSelEntryDlg * ScAbstractDialogFactory_Impl::CreateScSelEntryDlg (
vcl::Window* pParent,
+VclPtr<AbstractScSelEntryDlg>
ScAbstractDialogFactory_Impl::CreateScSelEntryDlg ( vcl::Window* pParent,
const
std::vector<OUString> &rEntryList )
{
VclPtr<ScSelEntryDlg> pDlg = VclPtr<ScSelEntryDlg>::Create( pParent,
rEntryList );
return VclPtr<AbstractScSelEntryDlg_Impl>::Create( pDlg );
}
-AbstractScLinkedAreaDlg *
ScAbstractDialogFactory_Impl::CreateScLinkedAreaDlg(vcl::Window* pParent)
+VclPtr<AbstractScLinkedAreaDlg>
ScAbstractDialogFactory_Impl::CreateScLinkedAreaDlg(vcl::Window* pParent)
{
VclPtr<ScLinkedAreaDlg> pDlg = VclPtr<ScLinkedAreaDlg>::Create( pParent );
return VclPtr<AbstractScLinkedAreaDlg_Impl>::Create( pDlg );
}
-AbstractScMetricInputDlg *
ScAbstractDialogFactory_Impl::CreateScMetricInputDlg ( vcl::Window*
pParent,
+VclPtr<AbstractScMetricInputDlg>
ScAbstractDialogFactory_Impl::CreateScMetricInputDlg ( vcl::Window*
pParent,
const OString&
sDialogName,
long
nCurrent,
long
nDefault,
@@ -748,33 +748,33 @@ AbstractScMetricInputDlg *
ScAbstractDialogFactory_Impl::CreateScMetricInputDlg
return VclPtr<AbstractScMetricInputDlg_Impl>::Create( pDlg );
}
-AbstractScMoveTableDlg *
ScAbstractDialogFactory_Impl::CreateScMoveTableDlg(vcl::Window* pParent,
+VclPtr<AbstractScMoveTableDlg>
ScAbstractDialogFactory_Impl::CreateScMoveTableDlg(vcl::Window* pParent,
const OUString& rDefault)
{
VclPtr<ScMoveTableDlg> pDlg = VclPtr<ScMoveTableDlg>::Create( pParent,
rDefault );
return VclPtr<AbstractScMoveTableDlg_Impl>::Create( pDlg );
}
-AbstractScNameCreateDlg *
ScAbstractDialogFactory_Impl::CreateScNameCreateDlg(vcl::Window * pParent,
sal_uInt16 nFlags)
+VclPtr<AbstractScNameCreateDlg>
ScAbstractDialogFactory_Impl::CreateScNameCreateDlg(vcl::Window * pParent,
sal_uInt16 nFlags)
{
VclPtr<ScNameCreateDlg> pDlg = VclPtr<ScNameCreateDlg>::Create( pParent,
nFlags );
return VclPtr<AbstractScNameCreateDlg_Impl>::Create( pDlg );
}
-AbstractScNamePasteDlg * ScAbstractDialogFactory_Impl::CreateScNamePasteDlg (
vcl::Window * pParent, ScDocShell* pShell, bool bInsList )
+VclPtr<AbstractScNamePasteDlg>
ScAbstractDialogFactory_Impl::CreateScNamePasteDlg ( vcl::Window * pParent,
ScDocShell* pShell, bool bInsList )
{
VclPtr<ScNamePasteDlg> pDlg = VclPtr<ScNamePasteDlg>::Create( pParent,
pShell, bInsList );
return VclPtr<AbstractScNamePasteDlg_Impl>::Create( pDlg );
}
-AbstractScPivotFilterDlg *
ScAbstractDialogFactory_Impl::CreateScPivotFilterDlg(vcl::Window* pParent,
+VclPtr<AbstractScPivotFilterDlg>
ScAbstractDialogFactory_Impl::CreateScPivotFilterDlg(vcl::Window* pParent,
const SfxItemSet& rArgSet, sal_uInt16 nSourceTab)
{
VclPtr<ScPivotFilterDlg> pDlg = VclPtr<ScPivotFilterDlg>::Create(pParent,
rArgSet, nSourceTab);
return VclPtr<AbstractScPivotFilterDlg_Impl>::Create(pDlg);
}
-AbstractScDPFunctionDlg * ScAbstractDialogFactory_Impl::CreateScDPFunctionDlg
( vcl::Window* pParent,
+VclPtr<AbstractScDPFunctionDlg>
ScAbstractDialogFactory_Impl::CreateScDPFunctionDlg ( vcl::Window* pParent,
const
ScDPLabelDataVector& rLabelVec,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData )
@@ -783,7 +783,7 @@ AbstractScDPFunctionDlg *
ScAbstractDialogFactory_Impl::CreateScDPFunctionDlg (
return VclPtr<AbstractScDPFunctionDlg_Impl>::Create( pDlg );
}
-AbstractScDPSubtotalDlg * ScAbstractDialogFactory_Impl::CreateScDPSubtotalDlg
( vcl::Window* pParent,
+VclPtr<AbstractScDPSubtotalDlg>
ScAbstractDialogFactory_Impl::CreateScDPSubtotalDlg ( vcl::Window* pParent,
ScDPObject&
rDPObj,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData,
@@ -793,39 +793,39 @@ AbstractScDPSubtotalDlg *
ScAbstractDialogFactory_Impl::CreateScDPSubtotalDlg (
return VclPtr<AbstractScDPSubtotalDlg_Impl>::Create( pDlg );
}
-AbstractScDPNumGroupDlg * ScAbstractDialogFactory_Impl::CreateScDPNumGroupDlg(
+VclPtr<AbstractScDPNumGroupDlg>
ScAbstractDialogFactory_Impl::CreateScDPNumGroupDlg(
vcl::Window* pParent, const ScDPNumGroupInfo& rInfo )
{
return VclPtr<AbstractScDPNumGroupDlg_Impl>::Create(
VclPtr<ScDPNumGroupDlg>::Create( pParent, rInfo ) );
}
-AbstractScDPDateGroupDlg *
ScAbstractDialogFactory_Impl::CreateScDPDateGroupDlg(
+VclPtr<AbstractScDPDateGroupDlg>
ScAbstractDialogFactory_Impl::CreateScDPDateGroupDlg(
vcl::Window* pParent,
const ScDPNumGroupInfo& rInfo, sal_Int32 nDatePart, const Date&
rNullDate )
{
return VclPtr<AbstractScDPDateGroupDlg_Impl>::Create(
VclPtr<ScDPDateGroupDlg>::Create( pParent, rInfo, nDatePart, rNullDate ) );
}
-AbstractScDPShowDetailDlg *
ScAbstractDialogFactory_Impl::CreateScDPShowDetailDlg (
+VclPtr<AbstractScDPShowDetailDlg>
ScAbstractDialogFactory_Impl::CreateScDPShowDetailDlg (
vcl::Window* pParent, ScDPObject& rDPObj, sal_uInt16 nOrient )
{
return VclPtr<AbstractScDPShowDetailDlg_Impl>::Create(
VclPtr<ScDPShowDetailDlg>::Create( pParent, rDPObj, nOrient ) );
}
-AbstractScNewScenarioDlg *
ScAbstractDialogFactory_Impl::CreateScNewScenarioDlg(vcl::Window* pParent,
const OUString& rName,
+VclPtr<AbstractScNewScenarioDlg>
ScAbstractDialogFactory_Impl::CreateScNewScenarioDlg(vcl::Window* pParent,
const OUString& rName,
bool bEdit, bool bSheetProtected)
{
VclPtr<ScNewScenarioDlg> pDlg = VclPtr<ScNewScenarioDlg>::Create(pParent,
rName, bEdit, bSheetProtected);
return VclPtr<AbstractScNewScenarioDlg_Impl>::Create( pDlg );
}
-AbstractScShowTabDlg *
ScAbstractDialogFactory_Impl::CreateScShowTabDlg(vcl::Window* pParent)
+VclPtr<AbstractScShowTabDlg>
ScAbstractDialogFactory_Impl::CreateScShowTabDlg(vcl::Window* pParent)
{
VclPtr<ScShowTabDlg> pDlg = VclPtr<ScShowTabDlg>::Create( pParent);
return VclPtr<AbstractScShowTabDlg_Impl>::Create( pDlg );
}
-AbstractScStringInputDlg *
ScAbstractDialogFactory_Impl::CreateScStringInputDlg ( vcl::Window* pParent,
+VclPtr<AbstractScStringInputDlg>
ScAbstractDialogFactory_Impl::CreateScStringInputDlg ( vcl::Window* pParent,
const
OUString& rTitle,
const
OUString& rEditTitle,
const
OUString& rDefault,
@@ -835,7 +835,7 @@ AbstractScStringInputDlg *
ScAbstractDialogFactory_Impl::CreateScStringInputDlg
return VclPtr<AbstractScStringInputDlg_Impl>::Create( pDlg );
}
-AbstractScTabBgColorDlg * ScAbstractDialogFactory_Impl::CreateScTabBgColorDlg(
+VclPtr<AbstractScTabBgColorDlg>
ScAbstractDialogFactory_Impl::CreateScTabBgColorDlg(
vcl::Window*
pParent,
const OUString&
rTitle,
const OUString&
rTabBgColorNoColorText,
@@ -845,7 +845,7 @@ AbstractScTabBgColorDlg *
ScAbstractDialogFactory_Impl::CreateScTabBgColorDlg(
return VclPtr<AbstractScTabBgColorDlg_Impl>::Create( pDlg );
}
-AbstractScImportOptionsDlg *
ScAbstractDialogFactory_Impl::CreateScImportOptionsDlg (
+VclPtr<AbstractScImportOptionsDlg>
ScAbstractDialogFactory_Impl::CreateScImportOptionsDlg (
bool
bAscii,
const
ScImportOptions* pOptions,
const
OUString* pStrTitle,
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx
b/sc/source/ui/attrdlg/scdlgfact.hxx
index 19f5747..5af8440 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -409,40 +409,40 @@ class ScAbstractDialogFactory_Impl : public
ScAbstractDialogFactory
public:
virtual ~ScAbstractDialogFactory_Impl() {}
- virtual VclPtr<AbstractScImportAsciiDlg> CreateScImportAsciiDlg( const
OUString& aDatName,
+ virtual VclPtr<AbstractScImportAsciiDlg> CreateScImportAsciiDlg( const
OUString& aDatName,
SvStream*
pInStream,
ScImportAsciiCall eCall) override;
- virtual AbstractScTextImportOptionsDlg * CreateScTextImportOptionsDlg()
override;
+ virtual VclPtr<AbstractScTextImportOptionsDlg>
CreateScTextImportOptionsDlg() override;
- virtual AbstractScAutoFormatDlg * CreateScAutoFormatDlg(vcl::Window*
pParent,
+ virtual VclPtr<AbstractScAutoFormatDlg> CreateScAutoFormatDlg(vcl::Window*
pParent,
ScAutoFormat*
pAutoFormat,
const
ScAutoFormatData* pSelFormatData,
ScViewData
*pViewData) override;
- virtual AbstractScColRowLabelDlg * CreateScColRowLabelDlg (vcl::Window*
pParent,
+ virtual VclPtr<AbstractScColRowLabelDlg> CreateScColRowLabelDlg
(vcl::Window* pParent,
bool bCol,
bool bRow =
false) override;
- virtual AbstractScSortWarningDlg * CreateScSortWarningDlg(vcl::Window*
pParent, const OUString& rExtendText, const OUString& rCurrentText ) override;
+ virtual VclPtr<AbstractScSortWarningDlg>
CreateScSortWarningDlg(vcl::Window* pParent, const OUString& rExtendText, const
OUString& rCurrentText ) override;
- virtual AbstractScCondFormatManagerDlg*
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const
ScConditionalFormatList* pFormatList ) override;
+ virtual VclPtr<AbstractScCondFormatManagerDlg>
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const
ScConditionalFormatList* pFormatList ) override;
- virtual AbstractScDataPilotDatabaseDlg *
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) override;
+ virtual VclPtr<AbstractScDataPilotDatabaseDlg>
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) override;
- virtual AbstractScDataPilotSourceTypeDlg*
CreateScDataPilotSourceTypeDlg(vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataPilotSourceTypeDlg>
CreateScDataPilotSourceTypeDlg(vcl::Window* pParent,
bool bEnableExternal) override;
- virtual AbstractScDataPilotServiceDlg * CreateScDataPilotServiceDlg(
vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataPilotServiceDlg> CreateScDataPilotServiceDlg(
vcl::Window* pParent,
const
std::vector<OUString>& rServices ) override;
- virtual AbstractScDeleteCellDlg * CreateScDeleteCellDlg(vcl::Window*
pParent, bool bDisallowCellMove ) override;
+ virtual VclPtr<AbstractScDeleteCellDlg> CreateScDeleteCellDlg(vcl::Window*
pParent, bool bDisallowCellMove ) override;
//for dataform
- virtual AbstractScDataFormDlg* CreateScDataFormDlg(vcl::Window* pParent,
+ virtual VclPtr<AbstractScDataFormDlg> CreateScDataFormDlg(vcl::Window*
pParent,
ScTabViewShell* pTabViewShell) override;
- virtual AbstractScDeleteContentsDlg *
CreateScDeleteContentsDlg(vcl::Window* pParent) override;
+ virtual VclPtr<AbstractScDeleteContentsDlg>
CreateScDeleteContentsDlg(vcl::Window* pParent) override;
- virtual AbstractScFillSeriesDlg * CreateScFillSeriesDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScFillSeriesDlg> CreateScFillSeriesDlg(
vcl::Window* pParent,
ScDocument&
rDocument,
FillDir
eFillDir,
FillCmd
eFillCmd,
@@ -451,24 +451,24 @@ public:
double
fStep,
double
fMax,
sal_uInt16
nPossDir) override;
- virtual AbstractScGroupDlg * CreateAbstractScGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScGroupDlg> CreateAbstractScGroupDlg( vcl::Window*
pParent,
bool bUnGroup =
false) override;
- virtual AbstractScInsertCellDlg * CreateScInsertCellDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScInsertCellDlg> CreateScInsertCellDlg(
vcl::Window* pParent,
bool
bDisallowCellMove ) override;
- virtual AbstractScInsertContentsDlg * CreateScInsertContentsDlg(
vcl::Window* pParent,
+ virtual VclPtr<AbstractScInsertContentsDlg> CreateScInsertContentsDlg(
vcl::Window* pParent,
const
OUString* pStrTitle = nullptr ) override;
- virtual AbstractScInsertTableDlg * CreateScInsertTableDlg(vcl::Window*
pParent, ScViewData& rViewData,
+ virtual VclPtr<AbstractScInsertTableDlg>
CreateScInsertTableDlg(vcl::Window* pParent, ScViewData& rViewData,
SCTAB nTabCount, bool bFromFile) override;
- virtual AbstractScSelEntryDlg * CreateScSelEntryDlg ( vcl::Window* pParent,
+ virtual VclPtr<AbstractScSelEntryDlg> CreateScSelEntryDlg ( vcl::Window*
pParent,
const
std::vector<OUString> &rEntryList ) override;
- virtual AbstractScLinkedAreaDlg * CreateScLinkedAreaDlg(vcl::Window*
pParent) override;
+ virtual VclPtr<AbstractScLinkedAreaDlg> CreateScLinkedAreaDlg(vcl::Window*
pParent) override;
- virtual AbstractScMetricInputDlg * CreateScMetricInputDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScMetricInputDlg> CreateScMetricInputDlg (
vcl::Window* pParent,
const OString&
sDialogName,
long
nCurrent,
long
nDefault,
@@ -477,56 +477,56 @@ public:
long
nMaximum = 1000,
long
nMinimum = 0 ) override;
- virtual AbstractScMoveTableDlg * CreateScMoveTableDlg(vcl::Window *
pParent,
+ virtual VclPtr<AbstractScMoveTableDlg> CreateScMoveTableDlg(vcl::Window *
pParent,
const OUString& rDefault) override;
- virtual AbstractScNameCreateDlg * CreateScNameCreateDlg(vcl::Window *
pParent,
+ virtual VclPtr<AbstractScNameCreateDlg> CreateScNameCreateDlg(vcl::Window
* pParent,
sal_uInt16 nFlags) override;
- virtual AbstractScNamePasteDlg * CreateScNamePasteDlg ( vcl::Window *
pParent, ScDocShell* pShell, bool bInsList=true ) override;
+ virtual VclPtr<AbstractScNamePasteDlg> CreateScNamePasteDlg ( vcl::Window
* pParent, ScDocShell* pShell, bool bInsList=true ) override;
- virtual AbstractScPivotFilterDlg * CreateScPivotFilterDlg(vcl::Window*
pParent,
+ virtual VclPtr<AbstractScPivotFilterDlg>
CreateScPivotFilterDlg(vcl::Window* pParent,
const SfxItemSet& rArgSet, sal_uInt16 nSourceTab) override;
- virtual AbstractScDPFunctionDlg * CreateScDPFunctionDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPFunctionDlg> CreateScDPFunctionDlg(
vcl::Window* pParent,
const
ScDPLabelDataVector& rLabelVec,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData ) override;
- virtual AbstractScDPSubtotalDlg * CreateScDPSubtotalDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPSubtotalDlg> CreateScDPSubtotalDlg(
vcl::Window* pParent,
ScDPObject&
rDPObj,
const
ScDPLabelData& rLabelData,
const
ScPivotFuncData& rFuncData,
const
ScDPNameVec& rDataFields ) override;
- virtual AbstractScDPNumGroupDlg * CreateScDPNumGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPNumGroupDlg> CreateScDPNumGroupDlg(
vcl::Window* pParent,
const
ScDPNumGroupInfo& rInfo ) override;
- virtual AbstractScDPDateGroupDlg * CreateScDPDateGroupDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPDateGroupDlg> CreateScDPDateGroupDlg(
vcl::Window* pParent,
const
ScDPNumGroupInfo& rInfo,
sal_Int32
nDatePart,
const Date&
rNullDate ) override;
- virtual AbstractScDPShowDetailDlg * CreateScDPShowDetailDlg( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScDPShowDetailDlg> CreateScDPShowDetailDlg(
vcl::Window* pParent,
ScDPObject&
rDPObj,
sal_uInt16
nOrient ) override;
- virtual AbstractScNewScenarioDlg * CreateScNewScenarioDlg ( vcl::Window*
pParent, const OUString& rName,
+ virtual VclPtr<AbstractScNewScenarioDlg> CreateScNewScenarioDlg (
vcl::Window* pParent, const OUString& rName,
bool bEdit,
bool bSheetProtected = false ) override;
- virtual AbstractScShowTabDlg * CreateScShowTabDlg(vcl::Window* pParent)
override;
+ virtual VclPtr<AbstractScShowTabDlg> CreateScShowTabDlg(vcl::Window*
pParent) override;
- virtual AbstractScStringInputDlg * CreateScStringInputDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScStringInputDlg> CreateScStringInputDlg (
vcl::Window* pParent,
const
OUString& rTitle,
const
OUString& rEditTitle,
const
OUString& rDefault,
const OString&
sHelpId, const OString& sEditHelpId ) override;
- virtual AbstractScTabBgColorDlg * CreateScTabBgColorDlg ( vcl::Window*
pParent,
+ virtual VclPtr<AbstractScTabBgColorDlg> CreateScTabBgColorDlg (
vcl::Window* pParent,
const
OUString& rTitle, //Dialog Title
const
OUString& rTabBgColorNoColorText, //Label for no tab color
const Color&
rDefaultColor ) override; //Currently selected Color
- virtual AbstractScImportOptionsDlg * CreateScImportOptionsDlg ( bool
bAscii,
+ virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool
bAscii,
const
ScImportOptions* pOptions = nullptr,
const
OUString* pStrTitle = nullptr,
bool
bMultiByte = false,
@@ -556,7 +556,7 @@ public:
virtual VclPtr<SfxAbstractTabDialog> CreateScSortDlg(vcl::Window* pParent,
const SfxItemSet* pArgSet) override;
// For TabPage
- virtual CreateTabPage GetTabPageCreatorFunc( sal_uInt16 nId
) override;
+ virtual CreateTabPage GetTabPageCreatorFunc( sal_uInt16 nId
) override;
};
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
