sal/qa/rtl/strings/test_oustring_stringliterals.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit ba8e95d0e86682349f377480e65fbf4641ef27f2
Author: Stephan Bergmann <sberg...@redhat.com>
Date:   Tue Dec 6 11:33:36 2016 +0100

    Comment cppcheck accessForwarded as harmless
    
    Change-Id: I2692ba63f010b61e7b4c1fe54368f4dac9c42d60

diff --git a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx 
b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
index 27f7080..1a40117 100644
--- a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
+++ b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
@@ -59,6 +59,9 @@ CPPUNIT_TEST_SUITE_END();
 template<typename T> bool VALID_CONVERSION( T && expression )
 {
     rtl_string_unittest_invalid_conversion = false;
+    // OK to std::forward expression twice; what is relevant in both ctor calls
+    // is not the content of the passed argument (which is ignored anyway by 
the
+    // special RTL_STRING_UNITTEST ctors) but only its type:
     ( void ) rtl::OUString( std::forward<T>(expression) );
     ( void ) rtl::OUStringBuffer( std::forward<T>(expression) );
     return !rtl_string_unittest_invalid_conversion;
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reply via email to