Hi, On Mon, Sep 04, 2017 at 02:30:06PM +0100, Tamas Zolnai wrote: > I just noticed that for makefiles (*.mk) git does not check whether the > commit contains tab indentation. As I know we use spaces also for makefiles > for indentation, right? So I added a patch changing pre-commit hook to check > tab also for makfiles: https://gerrit.libreoffice.org/#/c/41897/ I hope it's > ok. I don't know who used to care of git stuff.
Late to this show, but yeah: GNU make still requires tabs for its rules/recipe syntax etc. That we get away with spaces is only because gbuild widely is macro calls with whitespace separated lists as arguments. And for those, tabs-vs-space doesnt matter. Best, Bjoern _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice