Hi, On Fri, Oct 27, 2017 at 02:15:18PM +0200, Jan Holesovsky <ke...@collabora.com> wrote: > I am not much a fan of having code rewritten between the time I check > my git log -p and between the push. > > Having said that, it would be surely possible to create a bot similar > to Jenkins that would do the style checking - and if there's a diff, it > would push the modified version as an updated patch set :-)
Yes, this is technically possible, though needs understanding how Jenkins, Gerrit, other TDF infra bits fit together -- compared to just hacking the git pre-commit perl script. Somebody needs to do that work. > Ie. no modification under the hands for people who use the style > checking themselves, but for those who don't do it, the bot would > rewrite their patch - does that work? I think it could, though that still means reformat will happen after git commit, so if you push a series of commits to gerrit, you can easily end up with conflicts. If the style check happens at commit time, this is not an issue. Regards, Miklos
signature.asc
Description: Digital signature
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
