sd/source/ui/framework/module/ImpressModule.cxx | 3 ---
1 file changed, 3 deletions(-)
New commits:
commit ee82c5b96898bb73f5df6fdda7da1f04c3c375cc
Author: Caolán McNamara <caol...@redhat.com>
Date: Wed Nov 15 15:01:33 2017 +0000
impress constantly trying to create an internal SidebarView
I think since the sidebar was integrated that this is dead
code belonging to the sidebars impress-only ancestor
Nothing creates the SidebarView[1], so attempt fails, a failed attempt
is scheduled in to try again on a configuration update timer
configuration update timer fails to load missing SidebarView
but broadcasts configuration update on each attemp
when the presenter console gets a configuration update it
refreshes its ui by loading the current slide
if the current slide has notes and those notes are long enough
to be scrolled and the user has scrolled to the end, then when the
slide is reloaded the notes are at the top again.
So presenter console notes scroll to the top after 5 seconds because
the configuration update fired, because the previous configuration
update didn't work.
This is old lady that swallowed a fly level stuff
[1] and I think its a typo here anyway and msSidebarViewURL should have
been msSidebarPaneURL
Change-Id: Ibfff16bb1092a49a8a54ca9697b5dc3819448af3
Reviewed-on: https://gerrit.libreoffice.org/44766
Tested-by: Jenkins <c...@libreoffice.org>
Reviewed-by: Caolán McNamara <caol...@redhat.com>
Tested-by: Caolán McNamara <caol...@redhat.com>
diff --git a/sd/source/ui/framework/module/ImpressModule.cxx
b/sd/source/ui/framework/module/ImpressModule.cxx
index 640783c41654..bf2ee2472c93 100644
--- a/sd/source/ui/framework/module/ImpressModule.cxx
+++ b/sd/source/ui/framework/module/ImpressModule.cxx
@@ -43,9 +43,6 @@ void ImpressModule::Initialize (Reference<frame::XController>
const & rxControll
new SlideSorterModule(
rxController,
FrameworkHelper::msLeftImpressPaneURL);
- new ToolPanelModule(
- rxController,
- FrameworkHelper::msSidebarViewURL);
new ToolBarModule(rxController);
new ShellStackGuard(rxController);
}
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
