I wasn’t aware of this.

Is there a wiki page on this, or is this one of those things where you must be 
closely following the dev mailing list? 

Again, another instance where a convention I wasn’t aware of has got me caught 
out. Rather feels like I’m being picked on, as per normal. 

Chris

Sent from my iPad

> On 6 Mar 2018, at 8:25 pm, Stephan Bergmann <sberg...@redhat.com> wrote:
> 
>> On 17.11.2017 10:03, Stephan Bergmann wrote:
>> * Don't reformat when moving an existing file
>> When moving an old file that is listed in solenv/clang-format/blacklist (so 
>> doesn't automatically get reformatted upon commit), adapt 
>> solenv/clang-format/blacklist to contain the new name, instead of provoking 
>> a reformat upon commit.  Otherwise, if the reformatted code looks 
>> sufficiently different from the original, it's hard to impossible to keep 
>> track in the git history of which file was moved where.
> 
> Please also follow this advice when moving part of an existing file out to a 
> new file, as happened e.g. at 
> <https://cgit.freedesktop.org/libreoffice/core/commit/?id=bdd62b4c327ab894dbba00fe2e07696c1b7d9de6>
>  "vcl: split painting bitmap functions to bitmappaint.cxx".
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to