sw/source/filter/ww8/docxsdrexport.cxx | 2 +- sw/source/filter/ww8/docxsdrexport.hxx | 2 +- writerfilter/source/rtftok/rtfsprm.cxx | 2 +- writerfilter/source/rtftok/rtfsprm.hxx | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-)
New commits: commit a463287a3bf12ee3f6f58311e2629da19e6d014b Author: Miklos Vajna <[email protected]> AuthorDate: Tue Oct 16 22:54:28 2018 +0200 Commit: Miklos Vajna <[email protected]> CommitDate: Wed Oct 17 10:51:04 2018 +0200 sw, writerfilter: avoid some unnecessary value parameters Change-Id: I409eb644bdf519e097c87911b90f83c5ecd913ee Reviewed-on: https://gerrit.libreoffice.org/61853 Tested-by: Jenkins Reviewed-by: Miklos Vajna <[email protected]> diff --git a/sw/source/filter/ww8/docxsdrexport.cxx b/sw/source/filter/ww8/docxsdrexport.cxx index 0335062cf984..d1f9f489c74a 100644 --- a/sw/source/filter/ww8/docxsdrexport.cxx +++ b/sw/source/filter/ww8/docxsdrexport.cxx @@ -193,7 +193,7 @@ struct DocxSdrExport::Impl bool checkFrameBtlr(SwNode* pStartNode, bool bDML); }; -DocxSdrExport::DocxSdrExport(DocxExport& rExport, sax_fastparser::FSHelperPtr pSerializer, +DocxSdrExport::DocxSdrExport(DocxExport& rExport, const sax_fastparser::FSHelperPtr& pSerializer, oox::drawingml::DrawingML* pDrawingML) : m_pImpl(o3tl::make_unique<Impl>(*this, rExport, pSerializer, pDrawingML)) { diff --git a/sw/source/filter/ww8/docxsdrexport.hxx b/sw/source/filter/ww8/docxsdrexport.hxx index 08fdf8649818..81a8da881381 100644 --- a/sw/source/filter/ww8/docxsdrexport.hxx +++ b/sw/source/filter/ww8/docxsdrexport.hxx @@ -55,7 +55,7 @@ class DocxSdrExport struct Impl; std::unique_ptr<Impl> m_pImpl; public: - DocxSdrExport(DocxExport& rExport, sax_fastparser::FSHelperPtr pSerializer, oox::drawingml::DrawingML* pDrawingML); + DocxSdrExport(DocxExport& rExport, const sax_fastparser::FSHelperPtr& pSerializer, oox::drawingml::DrawingML* pDrawingML); ~DocxSdrExport(); void setSerializer(const sax_fastparser::FSHelperPtr& pSerializer); diff --git a/writerfilter/source/rtftok/rtfsprm.cxx b/writerfilter/source/rtftok/rtfsprm.cxx index f5f32f186d42..a4f3b81be211 100644 --- a/writerfilter/source/rtftok/rtfsprm.cxx +++ b/writerfilter/source/rtftok/rtfsprm.cxx @@ -76,7 +76,7 @@ RTFValue::Pointer_t RTFSprms::find(Id nKeyword, bool bFirst, bool bForWrite) return pValue; } -void RTFSprms::set(Id nKeyword, RTFValue::Pointer_t pValue, RTFOverwrite eOverwrite) +void RTFSprms::set(Id nKeyword, const RTFValue::Pointer_t& pValue, RTFOverwrite eOverwrite) { ensureCopyBeforeWrite(); diff --git a/writerfilter/source/rtftok/rtfsprm.hxx b/writerfilter/source/rtftok/rtfsprm.hxx index e46a7b68881f..cc5fb73ff13f 100644 --- a/writerfilter/source/rtftok/rtfsprm.hxx +++ b/writerfilter/source/rtftok/rtfsprm.hxx @@ -55,7 +55,8 @@ public: RTFValue::Pointer_t find(Id nKeyword, bool bFirst = true, bool bForWrite = false); /// Does the same as ->push_back(), except that it can overwrite or ignore existing entries. - void set(Id nKeyword, RTFValue::Pointer_t pValue, RTFOverwrite eOverwrite = RTFOverwrite::YES); + void set(Id nKeyword, const RTFValue::Pointer_t& pValue, + RTFOverwrite eOverwrite = RTFOverwrite::YES); bool erase(Id nKeyword); void eraseLast(Id nKeyword); /// Removes elements which are already in the reference set. _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
