Hi there,

On Thu, 2012-02-09 at 21:15 +0100, Santiago Martinez wrote:
> Hello, in file comphelper/qa/string/test_string.cxx there is a missing
> unit test to check the method "islowerAsciiString(rtl::OString
> const&)". Attached to this mail there is a patch to add this new test.
> Please review.

        Wow ! :-) having people to write unit tests is cool.

        So sorry you picked something that Stephan wrote out shortly
afterwards !

        It seems that tons of the unit tests in sal/ are compiled and not run,
since they're missing things like:

        CPPUNIT_REGISTRY_ADD_TO_DEFAULT( "osl_File" );

        That adds the osl_File set of tests to the default run list :-) perhaps
that'd be a good place to look at re-enabling and fixing some of those
existing tests: although, I guess of those file ones several are broken
(sadly).

        All the best,

                Michael.

-- 
[email protected]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to