wsd/TileCache.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
New commits: commit 0d5ee512b34e822a539882cd8ffe37ee83632c0d Author: Miklos Vajna <[email protected]> AuthorDate: Fri Mar 8 08:37:14 2019 +0100 Commit: Miklos Vajna <[email protected]> CommitDate: Fri Mar 8 08:37:14 2019 +0100 wsd, tile cache: avoid copy in loop when result is only used as const ref Change-Id: I7f5d3b0a52c5257b8e8d23fb2eafb5919aaae5f6 diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp index 26789a4c9..287e0ba77 100644 --- a/wsd/TileCache.cpp +++ b/wsd/TileCache.cpp @@ -559,7 +559,7 @@ void TileCache::saveDataToStreamCache(StreamType type, const std::string &fileNa void TileCache::TileBeingRendered::dumpState(std::ostream& os) { os << " " << _tile.serialize() << " " << std::setw(4) << getElapsedTimeMs() << "ms " << _subscribers.size() << " subscribers\n"; - for (auto it : _subscribers) + for (const auto& it : _subscribers) { std::shared_ptr<ClientSession> session = it.lock(); os << " " << session->getId() << " " << session->getUserId() << " " << session->getName() << "\n"; @@ -570,12 +570,12 @@ void TileCache::dumpState(std::ostream& os) { { size_t num = 0, size = 0; - for (auto it : _cache) + for (const auto& it : _cache) { num++; size += it.second->size(); } os << " tile cache: num: " << num << " size: " << size << " bytes\n"; - for (auto it : _cache) + for (const auto& it : _cache) { os << " " << std::setw(4) << it.first.getWireId() << "\t" << std::setw(6) << it.second->size() << " bytes" @@ -584,15 +584,15 @@ void TileCache::dumpState(std::ostream& os) } int type = 0; - for (auto i : _streamCache) + for (const auto& i : _streamCache) { size_t num = 0, size = 0; - for (auto it : i) + for (const auto& it : i) { num++; size += it.second->size(); } os << " stream cache: " << type++ << " num: " << num << " size: " << size << " bytes\n"; - for (auto it : i) + for (const auto& it : i) { os << " " << it.first << "\t" << std::setw(6) << it.second->size() << " bytes\n"; @@ -600,7 +600,7 @@ void TileCache::dumpState(std::ostream& os) } os << " tiles being rendered " << _tilesBeingRendered.size() << "\n"; - for (auto it : _tilesBeingRendered) + for (const auto& it : _tilesBeingRendered) it.second->dumpState(os); } _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
