qadevOOo/Jar_OOoRunner.mk                                                |    
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSubTotalDescriptorBase.csv |    
7 
 qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase.java                |  
122 ----------
 sc/qa/extras/scsubtotaldescriptorbase.cxx                                |    
9 
 sc/qa/unoapi/sc_7.sce                                                    |    
1 
 5 files changed, 9 insertions(+), 131 deletions(-)

New commits:
commit 554bae3e550fb3c64473851bf9a24cb4a2eabdd8
Author:     Jens Carl <j.car...@gmx.de>
AuthorDate: Mon Apr 1 06:28:54 2019 +0000
Commit:     Jens Carl <j.car...@gmx.de>
CommitDate: Mon Apr 1 16:41:48 2019 +0200

    tdf#45904 Move XPropertySet Java tests to C++
    
    Move XPropertySet Java tests to C++ for ScSubTotalDescriptorBase.
    
    Change-Id: I7fbfd244a9777b256098a1a7b8d3b2577cb71ebe
    Reviewed-on: https://gerrit.libreoffice.org/70041
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.car...@gmx.de>

diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 3539ddbfce9d..6a2a933132a8 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -969,7 +969,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
     qadevOOo/tests/java/mod/_sc/ScShapeObj \
     qadevOOo/tests/java/mod/_sc/ScSheetLinkObj \
     qadevOOo/tests/java/mod/_sc/ScStyleObj \
-    qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase \
     qadevOOo/tests/java/mod/_sc/ScTableColumnObj \
     qadevOOo/tests/java/mod/_sc/ScTableRowObj \
     qadevOOo/tests/java/mod/_sc/ScTableSheetObj \
diff --git 
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSubTotalDescriptorBase.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSubTotalDescriptorBase.csv
deleted file mode 100644
index 1bcb85bf438f..000000000000
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSubTotalDescriptorBase.csv
+++ /dev/null
@@ -1,7 +0,0 @@
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"setPropertyValue()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"getPropertyValue()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"addPropertyChangeListener()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"removePropertyChangeListener()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"addVetoableChangeListener()"
-"ScSubTotalDescriptorBase";"com::sun::star::beans::XPropertySet";"removeVetoableChangeListener()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase.java 
b/qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase.java
deleted file mode 100644
index f8254abb2700..000000000000
--- a/qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase.java
+++ /dev/null
@@ -1,122 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.container.XIndexAccess;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.GeneralFunction;
-import com.sun.star.sheet.SubTotalColumn;
-import com.sun.star.sheet.XSpreadsheet;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.sheet.XSpreadsheets;
-import com.sun.star.sheet.XSubTotalCalculatable;
-import com.sun.star.sheet.XSubTotalDescriptor;
-import com.sun.star.uno.AnyConverter;
-import com.sun.star.uno.Type;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-
-/**
-* Test for object which is represented by service
-* <code>com.sun.star.sheet.SubTotalDescriptor</code>. <p>
-* Object implements the following interfaces :
-* <ul>
-*  <li> <code>com::sun::star::sheet::XSubTotalDescriptor</code></li>
-*  <li> <code>com::sun::star::sheet::SubTotalDescriptor</code></li>
-*  <li> <code>com::sun::star::beans::XPropertySet</code></li>
-* </ul>
-* @see com.sun.star.sheet.XSubTotalDescriptor
-* @see com.sun.star.sheet.SubTotalDescriptor
-* @see com.sun.star.beans.XPropertySet
-* @see ifc.sheet._XSubTotalDescriptor
-* @see ifc.sheet._SubTotalDescriptor
-* @see ifc.beans._XPropertySet
-*/
-public class ScSubTotalDescriptorBase extends TestCase {
-    private XSpreadsheetDocument xSpreadsheetDoc;
-
-    /**
-    * Creates Spreadsheet document.
-    */
-    @Override
-    public void initialize( TestParameters Param, PrintWriter log ) throws 
Exception {
-        // get a soffice factory object
-        SOfficeFactory SOF = SOfficeFactory.getFactory( Param.getMSF());
-
-        log.println("creating a spreadsheetdocument");
-        xSpreadsheetDoc = SOF.createCalcDoc(null);
-    }
-
-    /**
-    * Disposes Spreadsheet document.
-    */
-    @Override
-    protected void cleanup( TestParameters tParam, PrintWriter log ) {
-        log.println( "    disposing xSheetDoc " );
-        XComponent oComp = UnoRuntime.queryInterface (XComponent.class, 
xSpreadsheetDoc) ;
-        util.DesktopTools.closeDoc(oComp);
-    }
-
-    /**
-    * Creating a TestEnvironment for the interfaces to be tested.
-    * Retrieves a collection of spreadsheets from the document and takes one of
-    * them. Creates a subtotal descriptor using the interface
-    * <code>XSubTotalCalculatable</code>. This descriptor is the instance of 
the
-    * service <code>com.sun.star.sheet.SubTotalDescriptor</code>.
-    * @see com.sun.star.sheet.XSubTotalCalculatable
-    * @see com.sun.star.sheet.SubTotalDescriptor
-    */
-    @Override
-    protected TestEnvironment createTestEnvironment(TestParameters Param, 
PrintWriter log) throws Exception {
-
-        log.println("getting sheets");
-        XSpreadsheets xSpreadsheets = xSpreadsheetDoc.getSheets();
-
-        log.println("getting a sheet");
-        XIndexAccess oIndexAccess = 
UnoRuntime.queryInterface(XIndexAccess.class, xSpreadsheets);
-        XSpreadsheet oSheet = (XSpreadsheet) AnyConverter.toObject(
-                new Type(XSpreadsheet.class),oIndexAccess.getByIndex(0));
-
-        XSubTotalCalculatable xSTC = 
UnoRuntime.queryInterface(XSubTotalCalculatable.class, oSheet);
-
-        SubTotalColumn[] columns = new SubTotalColumn[1];
-        SubTotalColumn column = new SubTotalColumn();
-        column.Column = 3;
-        column.Function = GeneralFunction.SUM;
-        columns[0] = column;
-
-        XSubTotalDescriptor desc = xSTC.createSubTotalDescriptor(true);
-        desc.addNew(columns, 1);
-
-        XInterface oObj = desc;
-
-        TestEnvironment tEnv = new TestEnvironment(oObj);
-        return tEnv;
-
-    } // finish method getTestEnvironment
-
-}    // finish class ScSubTotalDescriptorBase
diff --git a/sc/qa/extras/scsubtotaldescriptorbase.cxx 
b/sc/qa/extras/scsubtotaldescriptorbase.cxx
index 54176abd6ea1..96c6170a8cf1 100644
--- a/sc/qa/extras/scsubtotaldescriptorbase.cxx
+++ b/sc/qa/extras/scsubtotaldescriptorbase.cxx
@@ -8,6 +8,7 @@
  */
 
 #include <test/calc_unoapi_test.hxx>
+#include <test/beans/xpropertyset.hxx>
 #include <test/container/xelementaccess.hxx>
 #include <test/container/xenumerationaccess.hxx>
 #include <test/container/xindexaccess.hxx>
@@ -39,6 +40,7 @@ class ScSubTotalDescriptorBase : public CalcUnoApiTest,
                                  public apitest::XElementAccess,
                                  public apitest::XEnumerationAccess,
                                  public apitest::XIndexAccess,
+                                 public apitest::XPropertySet,
                                  public apitest::XSubTotalDescriptor
 {
 public:
@@ -64,6 +66,13 @@ public:
     CPPUNIT_TEST(testGetByIndex);
     CPPUNIT_TEST(testGetCount);
 
+    // XPropertySet
+    CPPUNIT_TEST(testGetPropertySetInfo);
+    CPPUNIT_TEST(testGetPropertyValue);
+    CPPUNIT_TEST(testSetPropertyValue);
+    CPPUNIT_TEST(testPropertyChangeListener);
+    CPPUNIT_TEST(testVetoableChangeListener);
+
     // XSubTotalDescriptor
     CPPUNIT_TEST(testAddNew);
     CPPUNIT_TEST(testClear);
diff --git a/sc/qa/unoapi/sc_7.sce b/sc/qa/unoapi/sc_7.sce
index 0744d8c3075f..82b38d8c8d0f 100644
--- a/sc/qa/unoapi/sc_7.sce
+++ b/sc/qa/unoapi/sc_7.sce
@@ -16,7 +16,6 @@
 #   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 #
 # -o sc.ScStyleObj
--o sc.ScSubTotalDescriptorBase
 # # i84656 -o sc.ScTabViewObj
 # -o sc.ScTableColumnObj
 # -o sc.ScTableRowObj
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reply via email to