[Libreoffice-commits] core.git: sc/qa

[Jens Carl (via logerrit)]

 sc/qa/extras/scheaderfieldsobj.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit e11dcc7e599830bedd3595c8b1427f47e5525c11
Author:     Jens Carl <j.car...@gmx.de>
AuthorDate: Mon Apr 15 03:37:57 2019 +0000
Commit:     Jens Carl <j.car...@gmx.de>
CommitDate: Mon Apr 15 06:42:08 2019 +0200

    Remove unnecessary calls to Reference::is() after an UNO_QUERY_THROW
    
    Change-Id: I43f7e328b45d0058f867f3296c5a34740d51b4da
    Reviewed-on: https://gerrit.libreoffice.org/70752
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.car...@gmx.de>

diff --git a/sc/qa/extras/scheaderfieldsobj.cxx 
b/sc/qa/extras/scheaderfieldsobj.cxx
index 89521b5270e1..e38e88fc0080 100644
--- a/sc/qa/extras/scheaderfieldsobj.cxx
+++ b/sc/qa/extras/scheaderfieldsobj.cxx
@@ -30,7 +30,6 @@
 #include <cppu/unotype.hxx>
 
 using namespace css;
-using namespace css::uno;
 
 namespace sc_apitest
 {
@@ -67,7 +66,6 @@ ScCellFieldsObj::ScCellFieldsObj()
 uno::Reference<uno::XInterface> ScCellFieldsObj::init()
 {
     uno::Reference<sheet::XSpreadsheetDocument> xDoc(m_xComponent, 
uno::UNO_QUERY_THROW);
-    CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
     uno::Reference<style::XStyleFamiliesSupplier> xSFS(xDoc, 
uno::UNO_QUERY_THROW);
     uno::Reference<container::XNameAccess> xNA(xSFS->getStyleFamilies(), 
uno::UNO_QUERY_THROW);
@@ -92,8 +90,8 @@ uno::Reference<uno::XInterface> ScCellFieldsObj::init()
 void ScCellFieldsObj::setUp()
 {
     CalcUnoApiTest::setUp();
+    // create calc document
     m_xComponent = loadFromDesktop("private:factory/scalc");
-    CPPUNIT_ASSERT_MESSAGE("no component", m_xComponent.is());
 }
 
 void ScCellFieldsObj::tearDown()
@@ -103,6 +101,7 @@ void ScCellFieldsObj::tearDown()
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScCellFieldsObj);
+
 } // namespace sc_apitest
 
 CPPUNIT_PLUGIN_IMPLEMENT();
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits