qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java | 2 +- sal/osl/unx/pipe.cxx | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
New commits: commit 5b52057a64ba9e78cf16c682e15f827d12a0e62e Author: Caolán McNamara <[email protected]> AuthorDate: Thu Jul 18 12:37:12 2019 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Jul 19 09:38:09 2019 +0200 cid#1448293 Copy into fixed size buffer Change-Id: I0ff36c58bf2448bdccc239582ba24b69c7431c6d Reviewed-on: https://gerrit.libreoffice.org/75921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Caolán McNamara <[email protected]> diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx index e9888e577ec5..c56c7a3c3d17 100644 --- a/sal/osl/unx/pipe.cxx +++ b/sal/osl/unx/pipe.cxx @@ -208,7 +208,8 @@ static oslPipe osl_psz_createPipe(const sal_Char *pszPipeName, oslPipeOptions Op SAL_INFO("sal.osl.pipe", "new pipe on fd " << pPipe->m_Socket << " '" << name << "'"); addr.sun_family = AF_UNIX; - strcpy(addr.sun_path, name.getStr()); // safe, see check above + // coverity[fixed_size_dest : FALSE] - safe, see check above + strcpy(addr.sun_path, name.getStr()); #if defined(FREEBSD) len = SUN_LEN(&addr); #else commit baf0502fe915365c09dabb9dc9eb08956ec4bcdc Author: Caolán McNamara <[email protected]> AuthorDate: Thu Jul 18 12:38:22 2019 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Jul 19 09:37:55 2019 +0200 cid#1448215 RV: Bad use of return value Change-Id: Ie974436b9d639a676336a95d5fef6545869e1ca8 Reviewed-on: https://gerrit.libreoffice.org/75922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Caolán McNamara <[email protected]> diff --git a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java index fa875234cbda..e262a15c8a33 100644 --- a/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java +++ b/qadevOOo/tests/java/ifc/view/_XMultiSelectionSupplier.java @@ -390,7 +390,7 @@ public class _XMultiSelectionSupplier extends MultiMethodTest { i--; if (ObjCompare != null) { - ObjCompare.compare(shouldElement, nextElement); + compRes = ObjCompare.compare(shouldElement, nextElement) == 0; } else { compRes = util.ValueComparer.equalValue(shouldElement, nextElement); } _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
