On 02/23/2012 12:22 PM, Michael Meeks wrote:
On Thu, 2012-02-23 at 10:56 +0100, Stephan Bergmann wrote:
Yes, fix should be good. With the newly added rtl::OUString ctor, a
string literal can now implicitly be converted to an rtl::OUString,
which can lead to ambiguities. In this case, SimpleResMgr has ctors
that take either a char const * or an rtl::OUString const&. Probably
something that should be cleaned up, leaving SimpleResMgr with just one
of the two ctors. (And CREATEVERSIONRESMGR_NAME is just a glorious
macro to turn its argument into a string literal, so can safely be dropped.)
Easy hack created:
https://bugs.freedesktop.org/show_bug.cgi?id=46501
Ha! I had already fixed that myself (seeing that it has only a handful
of uses); push pending.
We constantly need more of these, as they keep getting fixed
(somehow) ;-) so it'd be great if people can file/create them as/when
they notice code problems during reading.
Yes, you are right. It might have been better to resist the urge to
quickly fix it myself, and file an easy hack instead.
Stephan
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
