sc/source/core/data/documen6.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c3bde3b4bddb6bcfe0ae5b269d3b0f50c23236f
Author:     Luboš Luňák <>
AuthorDate: Tue Jan 14 12:26:52 2020 +0100
Commit:     Adolfo Jayme Barrientos <>
CommitDate: Thu Jan 16 01:47:24 2020 +0100

    do not ignore return value of a (confusing) function (tdf#126248)
    The two ScCellFormat::GetString() overloads are lame API, one returns
    the value normally and the other one returns void and uses a reference
    parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501
    and didn't use the return value in one case.
    Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6
    Tested-by: Jenkins
    Reviewed-by: 锁琨珑 <>
    Reviewed-by: Luboš Luňák <>
    (cherry picked from commit 5a211ba9f5f465c8c898ebce4cc37fa30581acac)
    Reviewed-by: Adolfo Jayme Barrientos <>

diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx
index 9dd1f8b523a3..bc0f7aa11afa 100644
--- a/sc/source/core/data/documen6.cxx
+++ b/sc/source/core/data/documen6.cxx
@@ -120,7 +120,7 @@ SvtScriptType ScDocument::GetCellScriptType( const 
ScAddress& rPos, sal_uInt32 n
     if( pCell )
         ScCellFormat::GetString(*pCell, nNumberFormat, aStr, &pColor, 
*mxPoolHelper->GetFormTable(), this);
-        ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, 
+        aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, 
     SvtScriptType nRet = GetStringScriptType( aStr );
Libreoffice-commits mailing list

Reply via email to