Am 20.03.2012 15:56, schrieb Caolán McNamara:
On Tue, 2012-03-20 at 13:54 +0000, Caolán McNamara wrote:
Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator
ctor is never called, and its the only constructor, so one is never
instantiated, so you can remove the whole thing without loss of
functionality.
Whoops, its PresenterAnimation (not PresenterAnimator) which has only
one ctor that is never used and so is never instantiated and is trivial
to remove.
A PresenterAnimation could be instantiated here

    ModeChangeAnimation (
        const ::boost::shared_ptr<PresenterSprite>& rpSprite,
        const Reference<rendering::XSpriteCanvas>& rxCanvas)
        : PresenterAnimation (0, 1000, 20),
          mpSprite(rpSprite),
          mxCanvas(rxCanvas)
    {
    }

in PresenterWindowManager.cxx - iff ModeChangeAnimation would be used anywhere. I can't find any place where it is used. Double check would be nice. So first ModeChangeAnimation would have to go, then PresenterAnimation could be removed as well.

Christina
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to