Hi Noel,

pushed after all (phew!) :) Added some corrections in the subsequent commits - see the git log.

But I wonder why in the following code... (chartpos.cxx:548)

            RowMap::const_iterator pPosIter = pCol2->begin();
            if ( pPosIter != pCol2->end() )
            {
                if ( nRowAdd )
                {
ppColHeader[ nCol ] = pPosIter->second; // eigenstaendig
                    ++pPosIter;
                }
                else
                    ppColHeader[ nCol ] = pPosIter->second ?
                        new ScAddress( *pPosIter->second ) : NULL;
            }

...pPosIter is not incremented in the else branch. I know - that logic was here before the conversion to std::map. But it looks weird...

Anyway, thank you for this work!

Ivan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to