Noel Power-3 wrote
>
>>...
>> I can commit and push on master of course but I'd like first your opinion
>> about this.
>>
> please commit looks like the correct fix to me ( on a side note can
> anyone remember what ( #if _SOLAR__PRIVATE ) is all about, I can't see
> any reason for it in the context of this code in anycase :-/ and would
> be tempted to delete it. And btw thanks, always a pleasure to come back
> from vacation to see something from the to do list fixed by someone else
> :-))) thanks again!!
>
> Noel
>
No problem, I'll do this as soon as get back home (so after day work :-) ).
BTW, I noticed that const_iterators were used. As a beginner, I don't
understand how const_iterators can work in this file whereas most of the
time the object referenced is modified, eg :
248 for( IDEWindowTable::const_iterator it =
aIDEWindowTable.begin(); it != aIDEWindowTable.end(); ++it )
249 {
250 // no store; does already happen when the BasicManagers are
destroyed
251 delete it->second;
252 }
338 for( std::vector<IDEBaseWindow*>::const_iterator it =
aDeleteVec.begin(); it != aDeleteVec.end(); ++it )
339 {
340 IDEBaseWindow* pWin = *it;
341 pWin->StoreData();
But perhaps I misunderstood something (which wouldn't be surprising :-))
Julien
--
View this message in context:
http://nabble.documentfoundation.org/PATCH-fix-proposed-for-fdo-48368-tp3910905p3914140.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
